Re: [PATCH 1/3] x86, acpi: Eliminate saved_eip

2015-06-17 Thread Pavel Machek
On Tue 2015-06-16 14:46:20, Denys Vlasenko wrote: > On 06/16/2015 12:05 PM, Pavel Machek wrote: > > > >> diff --git a/arch/x86/kernel/acpi/wakeup_32.S > >> b/arch/x86/kernel/acpi/wakeup_32.S > >> index 665c6b7..eef2bd3 100644 > >> --- a/arch/x86/kernel/acpi/wakeup_32.S > >> +++ b/arch/x86/kernel/

Re: [PATCH 1/3] x86, acpi: Eliminate saved_eip

2015-06-16 Thread Denys Vlasenko
On 06/16/2015 12:05 PM, Pavel Machek wrote: > >> diff --git a/arch/x86/kernel/acpi/wakeup_32.S >> b/arch/x86/kernel/acpi/wakeup_32.S >> index 665c6b7..eef2bd3 100644 >> --- a/arch/x86/kernel/acpi/wakeup_32.S >> +++ b/arch/x86/kernel/acpi/wakeup_32.S >> @@ -31,17 +31,11 @@ wakeup_pmode_return: >>

Re: [PATCH 1/3] x86, acpi: Eliminate saved_eip

2015-06-16 Thread Pavel Machek
> diff --git a/arch/x86/kernel/acpi/wakeup_32.S > b/arch/x86/kernel/acpi/wakeup_32.S > index 665c6b7..eef2bd3 100644 > --- a/arch/x86/kernel/acpi/wakeup_32.S > +++ b/arch/x86/kernel/acpi/wakeup_32.S > @@ -31,17 +31,11 @@ wakeup_pmode_return: > > movl%cs:saved_magic, %eax > cmpl

Re: [PATCH 1/3] x86, acpi: Eliminate saved_eip

2015-06-15 Thread Borislav Petkov
On Sun, Jun 14, 2015 at 03:23:08PM +0200, Denys Vlasenko wrote: > It always contains the address of "ret_point" label This commit message is very laconic - I had to go look at the code just to see what you mean. I guess it should be something like: "Get rid of the global variable saved_eip as it

[PATCH 1/3] x86, acpi: Eliminate saved_eip

2015-06-14 Thread Denys Vlasenko
It always contains the address of "ret_point" label Run-tested. Signed-off-by: Denys Vlasenko CC: Pavel Machek CC: Linus Torvalds CC: Steven Rostedt CC: Ingo Molnar CC: Borislav Petkov CC: "H. Peter Anvin" CC: Andy Lutomirski CC: Oleg Nesterov CC: Frederic Weisbecker CC: Alexei Starovoi