Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-24 Thread H. Peter Anvin
On 02/23/2014 11:56 PM, Jan Beulich wrote: 2.17 doesn't have support for it either, yet has support for fxsaveq (which you can see in the patch context we check for too). Apart from that Documentation/Changes continues to state binutils 2.12 to be the minimum requirement...

Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-24 Thread H. Peter Anvin
On 02/23/2014 11:56 PM, Jan Beulich wrote: 2.17 doesn't have support for it either, yet has support for fxsaveq (which you can see in the patch context we check for too). Apart from that Documentation/Changes continues to state binutils 2.12 to be the minimum requirement...

Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-23 Thread Jan Beulich
>>> On 21.02.14 at 20:17, "H. Peter Anvin" wrote: > On 02/21/2014 06:16 AM, Jan Beulich wrote: > On 21.02.14 at 13:51, "H. Peter Anvin" wrote: >>> How old? >> >> 2.16.91.0.5 (SLE10) >> > > I would *love* to kill off binutils 2.16. It was a horribly buggy > version, and it has been hard

Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-23 Thread Jan Beulich
On 21.02.14 at 20:17, H. Peter Anvin h...@zytor.com wrote: On 02/21/2014 06:16 AM, Jan Beulich wrote: On 21.02.14 at 13:51, H. Peter Anvin h...@zytor.com wrote: How old? 2.16.91.0.5 (SLE10) I would *love* to kill off binutils 2.16. It was a horribly buggy version, and it has been

Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-21 Thread H. Peter Anvin
On 02/21/2014 06:16 AM, Jan Beulich wrote: On 21.02.14 at 13:51, "H. Peter Anvin" wrote: >> How old? > > 2.16.91.0.5 (SLE10) > I would *love* to kill off binutils 2.16. It was a horribly buggy version, and it has been hard to deal with keeping things alive with it. How important is

Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-21 Thread Jan Beulich
>>> On 21.02.14 at 13:51, "H. Peter Anvin" wrote: > How old? 2.16.91.0.5 (SLE10) Jan > On February 21, 2014 2:32:50 AM PST, Jan Beulich wrote: >>Just like for other ISA extension instruction uses we should check >>whether the assembler actually supports them. The fallback here simply >>is to

Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-21 Thread H. Peter Anvin
How old? On February 21, 2014 2:32:50 AM PST, Jan Beulich wrote: >Just like for other ISA extension instruction uses we should check >whether the assembler actually supports them. The fallback here simply >is to encode an instruction with fixed operands (%eax and %ecx). > >Signed-off-by: Jan

[PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-21 Thread Jan Beulich
Just like for other ISA extension instruction uses we should check whether the assembler actually supports them. The fallback here simply is to encode an instruction with fixed operands (%eax and %ecx). Signed-off-by: Jan Beulich Cc: Francesco Fusco Cc: Daniel Borkmann Cc: Thomas Graf Cc:

[PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-21 Thread Jan Beulich
Just like for other ISA extension instruction uses we should check whether the assembler actually supports them. The fallback here simply is to encode an instruction with fixed operands (%eax and %ecx). Signed-off-by: Jan Beulich jbeul...@suse.com Cc: Francesco Fusco ffu...@redhat.com Cc: Daniel

Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-21 Thread H. Peter Anvin
How old? On February 21, 2014 2:32:50 AM PST, Jan Beulich jbeul...@suse.com wrote: Just like for other ISA extension instruction uses we should check whether the assembler actually supports them. The fallback here simply is to encode an instruction with fixed operands (%eax and %ecx).

Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-21 Thread Jan Beulich
On 21.02.14 at 13:51, H. Peter Anvin h...@zytor.com wrote: How old? 2.16.91.0.5 (SLE10) Jan On February 21, 2014 2:32:50 AM PST, Jan Beulich jbeul...@suse.com wrote: Just like for other ISA extension instruction uses we should check whether the assembler actually supports them. The fallback

Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

2014-02-21 Thread H. Peter Anvin
On 02/21/2014 06:16 AM, Jan Beulich wrote: On 21.02.14 at 13:51, H. Peter Anvin h...@zytor.com wrote: How old? 2.16.91.0.5 (SLE10) I would *love* to kill off binutils 2.16. It was a horribly buggy version, and it has been hard to deal with keeping things alive with it. How important is