Re: [PATCH 1/3] x86: apuv2: remove unused variable

2019-03-08 Thread Linus Walleij
On Fri, Mar 8, 2019 at 11:42 AM Enrico Weigelt, metux IT consult wrote: > On 08.03.19 10:11, Linus Walleij wrote: > > > As Torvalds did not yet pull the GPIO tree (maybe because of this > > and other bugs, who knows) I applied this to my GPIO tree for > > now. > > Great. I actually like it better

Re: [PATCH 1/3] x86: apuv2: remove unused variable

2019-03-08 Thread Enrico Weigelt, metux IT consult
On 08.03.19 10:11, Linus Walleij wrote: > As Torvalds did not yet pull the GPIO tree (maybe because of this > and other bugs, who knows) I applied this to my GPIO tree for > now. Great. I actually like it better this way, so his pull will be clean and consistent. Did you also apply the kconfig

Re: [PATCH 1/3] x86: apuv2: remove unused variable

2019-03-08 Thread Linus Walleij
On Mon, Mar 4, 2019 at 9:09 PM Arnd Bergmann wrote: > The driver was newly introduced but the version that got merged > produces a harmless compiler warning: > > drivers/platform/x86/pcengines-apuv2.c: In function 'apu_board_init': > drivers/platform/x86/pcengines-apuv2.c:211:6: error: unused

Re: [PATCH 1/3] x86: apuv2: remove unused variable

2019-03-05 Thread Andy Shevchenko
On Tue, Mar 5, 2019 at 2:04 AM Enrico Weigelt, metux IT consult wrote: > > On 04.03.19 21:19, Arnd Bergmann wrote: > > > diff --git a/drivers/platform/x86/pcengines-apuv2.c > > b/drivers/platform/x86/pcengines-apuv2.c > > index dcb084f6b892..c1ca931e1fab 100644 > > ---

Re: [PATCH 1/3] x86: apuv2: remove unused variable

2019-03-04 Thread Enrico Weigelt, metux IT consult
On 04.03.19 21:19, Arnd Bergmann wrote: > diff --git a/drivers/platform/x86/pcengines-apuv2.c > b/drivers/platform/x86/pcengines-apuv2.c > index dcb084f6b892..c1ca931e1fab 100644 > --- a/drivers/platform/x86/pcengines-apuv2.c > +++ b/drivers/platform/x86/pcengines-apuv2.c > @@ -208,7 +208,6 @@

[PATCH 1/3] x86: apuv2: remove unused variable

2019-03-04 Thread Arnd Bergmann
The driver was newly introduced but the version that got merged produces a harmless compiler warning: drivers/platform/x86/pcengines-apuv2.c: In function 'apu_board_init': drivers/platform/x86/pcengines-apuv2.c:211:6: error: unused variable 'rc' [-Werror=unused-variable] Remove the evidently

[PATCH 1/3] x86: apuv2: remove unused variable

2019-03-04 Thread Arnd Bergmann
The driver was newly introduced but the version that got merged produces a harmless compiler warning: drivers/platform/x86/pcengines-apuv2.c: In function 'apu_board_init': drivers/platform/x86/pcengines-apuv2.c:211:6: error: unused variable 'rc' [-Werror=unused-variable] Remove the evidently