Re: [PATCH 1/3 v2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-10-20 Thread Steven Rostedt
On Tue, 20 Oct 2020 13:59:46 +0200 Vlastimil Babka wrote: > Nice! I'm late here, but you mentioned a v3, so FWIW: > > Acked-by: Vlastimil Babka You are late ;-) afbe7973173a7ce0a68af8b33e44c967582297be -- Steve

Re: [PATCH 1/3 v2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-10-20 Thread Vlastimil Babka
On 9/25/20 11:12 PM, Steven Rostedt wrote: From: "Steven Rostedt (VMware)" As tracepoints are discouraged from being added in a header because it can cause side effects if other tracepoints are in headers, as well as bloat the kernel as the trace_() function is not a small inline, the common wo

Re: [PATCH 1/3 v2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-25 Thread Steven Rostedt
On Fri, 25 Sep 2020 14:36:37 -0700 Axel Rasmussen wrote: > > +In a C file:: > > + > > + void do_trace_foo_bar_wrapper(args) > > + { > > + trace_foo_bar(args); > > + } > > + > > +In the header file:: > > + > > + DECLEARE_TRACEPOINT(foo_bar); > > Should be "

Re: [PATCH 1/3 v2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-25 Thread Axel Rasmussen
On Fri, Sep 25, 2020 at 2:18 PM Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > As tracepoints are discouraged from being added in a header because it can > cause side effects if other tracepoints are in headers, as well as bloat the > kernel as the trace_() function is not a small

[PATCH 1/3 v2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-25 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" As tracepoints are discouraged from being added in a header because it can cause side effects if other tracepoints are in headers, as well as bloat the kernel as the trace_() function is not a small inline, the common workaround is to add a function call that calls