Re: [PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller

2020-10-09 Thread Lad, Prabhakar
Hi Pavel, Thank you for the review. On Fri, Oct 9, 2020 at 8:23 AM Pavel Machek wrote: > > Hi! > > > +&pciec { > > + /* SW2[6] determines which connector is activated > > + * ON = PCIe X4 (connector-J7) > > + * OFF = mini-PCIe (connector-J26) > > + */ > > + status = "okay"

Re: [PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller

2020-10-09 Thread Pavel Machek
Hi! > +&pciec { > + /* SW2[6] determines which connector is activated > + * ON = PCIe X4 (connector-J7) > + * OFF = mini-PCIe (connector-J26) > + */ > + status = "okay"; > +}; Note this is wrong comment style for non-network parts of kernel. Best regards,

Re: [PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller

2020-09-03 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Thu, Sep 3, 2020 at 11:18 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Tue, Aug 25, 2020 at 6:28 PM Lad Prabhakar > wrote: > > Enable PCIe Controller and set PCIe bus clock frequency. > > > > Signed-off-by: Lad Prabhakar > > Reviewed-by: Chris Pa

Re: [PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller

2020-09-03 Thread Geert Uytterhoeven
Hi Prabhakar, On Thu, Sep 3, 2020 at 1:18 PM Lad, Prabhakar wrote: > On Thu, Sep 3, 2020 at 11:18 AM Geert Uytterhoeven > wrote: > > On Tue, Aug 25, 2020 at 6:28 PM Lad Prabhakar > > wrote: > > > Enable PCIe Controller and set PCIe bus clock frequency. > > > > > > Signed-off-by: Lad Prabhakar

Re: [PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller

2020-09-03 Thread Geert Uytterhoeven
Hi Prabhakar, On Tue, Aug 25, 2020 at 6:28 PM Lad Prabhakar wrote: > Enable PCIe Controller and set PCIe bus clock frequency. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Chris Paterson Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v5.10. One thing to double-check b

[PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller

2020-08-25 Thread Lad Prabhakar
Enable PCIe Controller and set PCIe bus clock frequency. Signed-off-by: Lad Prabhakar Reviewed-by: Chris Paterson --- arch/arm/boot/dts/r8a7742-iwg21d-q7.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts b/arch/arm/boot/dts/r8a7742-iw