Re: [PATCH 1/4] Cleaned hexadecimal dump

2015-03-09 Thread Mark Brown
On Sat, Mar 07, 2015 at 12:56:32PM -0500, Adrian Remonda wrote: > +static void hexDump(const void *src, size_t length, size_t bLine, char > *prefix) > +{ Please call this hex_dump or something - that's more in line with the kernel coding style. Please also don't vUse aHungarian nNotation, it's

Re: [PATCH 1/4] Cleaned hexadecimal dump

2015-03-09 Thread Geert Uytterhoeven
On Sat, Mar 7, 2015 at 6:56 PM, Adrian Remonda wrote: > diff --git a/Documentation/spi/spidev_test.c b/Documentation/spi/spidev_test.c > index 3a2f9d59edab..533050ced9f1 100644 > --- a/Documentation/spi/spidev_test.c > +++ b/Documentation/spi/spidev_test.c > @@ -15,6 +15,7 @@ > #include > #incl

Re: [PATCH 1/4] Cleaned hexadecimal dump

2015-03-08 Thread Joe Perches
On Sun, 2015-03-08 at 12:53 +0200, Andy Shevchenko wrote: > On Sun, Mar 8, 2015 at 4:22 AM, Joe Perches wrote: > > On Sat, 2015-03-07 at 12:56 -0500, Adrian Remonda wrote: > > >> +static void hexDump(const void *src, size_t length, size_t bLine, char > >> *prefix) > > Is there something necessar

Re: [PATCH 1/4] Cleaned hexadecimal dump

2015-03-08 Thread Andy Shevchenko
On Sun, Mar 8, 2015 at 4:22 AM, Joe Perches wrote: > On Sat, 2015-03-07 at 12:56 -0500, Adrian Remonda wrote: >> +static void hexDump(const void *src, size_t length, size_t bLine, char >> *prefix) >> +{ > > Is there something necessary that print_hex_dump can't do? As far as I can see the tool

Re: [PATCH 1/4] Cleaned hexadecimal dump

2015-03-07 Thread Joe Perches
On Sat, 2015-03-07 at 12:56 -0500, Adrian Remonda wrote: > Signed-off-by: Adrian Remonda [] > diff --git a/Documentation/spi/spidev_test.c b/Documentation/spi/spidev_test.c [] > +static void hexDump(const void *src, size_t length, size_t bLine, char > *prefix) > +{ Is there something necessary t

[PATCH 1/4] Cleaned hexadecimal dump

2015-03-07 Thread Adrian Remonda
Signed-off-by: Adrian Remonda --- Documentation/spi/spidev_test.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/Documentation/spi/spidev_test.c b/Documentation/spi/spidev_test.c index 3a2f9d59edab..533050ced9f1 100644 --- a/Documentati