Re: [PATCH 1/4] HID: multitouch: fix Elan panels with 2 input modes declaration

2018-09-05 Thread Benjamin Tissoires
On Tue, Sep 4, 2018 at 9:31 PM Jiri Kosina wrote: > > On Tue, 4 Sep 2018, Benjamin Tissoires wrote: > > > When implementing commit 7f81c8db5489 ("HID: multitouch: simplify > > the settings of the various features"), I wrongly removed a test > > that made sure we never try to set the second

Re: [PATCH 1/4] HID: multitouch: fix Elan panels with 2 input modes declaration

2018-09-05 Thread Benjamin Tissoires
On Tue, Sep 4, 2018 at 9:31 PM Jiri Kosina wrote: > > On Tue, 4 Sep 2018, Benjamin Tissoires wrote: > > > When implementing commit 7f81c8db5489 ("HID: multitouch: simplify > > the settings of the various features"), I wrongly removed a test > > that made sure we never try to set the second

Re: [PATCH 1/4] HID: multitouch: fix Elan panels with 2 input modes declaration

2018-09-04 Thread Jiri Kosina
On Tue, 4 Sep 2018, Benjamin Tissoires wrote: > When implementing commit 7f81c8db5489 ("HID: multitouch: simplify > the settings of the various features"), I wrongly removed a test > that made sure we never try to set the second InputMode feature > to something else than 0. > > This broke badly

Re: [PATCH 1/4] HID: multitouch: fix Elan panels with 2 input modes declaration

2018-09-04 Thread Jiri Kosina
On Tue, 4 Sep 2018, Benjamin Tissoires wrote: > When implementing commit 7f81c8db5489 ("HID: multitouch: simplify > the settings of the various features"), I wrongly removed a test > that made sure we never try to set the second InputMode feature > to something else than 0. > > This broke badly

[PATCH 1/4] HID: multitouch: fix Elan panels with 2 input modes declaration

2018-09-04 Thread Benjamin Tissoires
When implementing commit 7f81c8db5489 ("HID: multitouch: simplify the settings of the various features"), I wrongly removed a test that made sure we never try to set the second InputMode feature to something else than 0. This broke badly some recent Elan panels that now forget to send the click

[PATCH 1/4] HID: multitouch: fix Elan panels with 2 input modes declaration

2018-09-04 Thread Benjamin Tissoires
When implementing commit 7f81c8db5489 ("HID: multitouch: simplify the settings of the various features"), I wrongly removed a test that made sure we never try to set the second InputMode feature to something else than 0. This broke badly some recent Elan panels that now forget to send the click