Re: [PATCH 1/4] Input: cyapa - Move common initialization to cyapa_detect

2013-03-16 Thread Henrik Rydberg
Hi Benson, > cyapa_check_is_operational and cyapa_create_input_dev are common to > the probe and firmware update paths. Pull those out into > cyapa_detect. > > Signed-off-by: Benson Leung > --- > drivers/input/mouse/cyapa.c | 57 > +++-- > 1 file

Re: [PATCH 1/4] Input: cyapa - Move common initialization to cyapa_detect

2013-03-16 Thread Henrik Rydberg
Hi Benson, cyapa_check_is_operational and cyapa_create_input_dev are common to the probe and firmware update paths. Pull those out into cyapa_detect. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/input/mouse/cyapa.c | 57 +++-- 1

[PATCH 1/4] Input: cyapa - Move common initialization to cyapa_detect

2013-03-13 Thread Benson Leung
cyapa_check_is_operational and cyapa_create_input_dev are common to the probe and firmware update paths. Pull those out into cyapa_detect. Signed-off-by: Benson Leung --- drivers/input/mouse/cyapa.c | 57 +++-- 1 file changed, 39 insertions(+), 18

[PATCH 1/4] Input: cyapa - Move common initialization to cyapa_detect

2013-03-13 Thread Benson Leung
cyapa_check_is_operational and cyapa_create_input_dev are common to the probe and firmware update paths. Pull those out into cyapa_detect. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/input/mouse/cyapa.c | 57 +++-- 1 file changed, 39