Re: [PATCH 1/4] Input: uinput: add full absinfo support

2014-01-12 Thread Dmitry Torokhov
On Thu, Dec 19, 2013 at 08:27:32AM +1000, Peter Hutterer wrote: > On Tue, Dec 17, 2013 at 04:48:51PM +0100, David Herrmann wrote: > > + > > + user_dev2->version = UINPUT_VERSION; > > + memcpy(user_dev2->name, user_dev->name, UINPUT_MAX_NAME_SIZE); > > + memcpy(&user_dev2->id, &user_dev->id, s

Re: [PATCH 1/4] Input: uinput: add full absinfo support

2014-01-12 Thread Dmitry Torokhov
On Tue, Dec 17, 2013 at 04:48:51PM +0100, David Herrmann wrote: > + > +struct uinput_user_dev2 { > + __u8 version; It does not make sense to have version u8 since we going to have padding (1 byte I believe) padding between name and id. > + char name[UINPUT_MAX_NAME_SIZE]; > + struct

Re: [PATCH 1/4] Input: uinput: add full absinfo support

2013-12-18 Thread Peter Hutterer
On Tue, Dec 17, 2013 at 04:48:51PM +0100, David Herrmann wrote: > We currently lack support for abs-resolution and abs-value parameters > during uinput ABS initialization. Furthermore, our parsers don't allow > growing ABS_CNT values. Therefore, introduce uinput_user_dev2. > > User-space is free t

[PATCH 1/4] Input: uinput: add full absinfo support

2013-12-17 Thread David Herrmann
We currently lack support for abs-resolution and abs-value parameters during uinput ABS initialization. Furthermore, our parsers don't allow growing ABS_CNT values. Therefore, introduce uinput_user_dev2. User-space is free to write uinput_user_dev2 objects instead of uinput_user_dev legacy objects