Re: [PATCH 1/4] arm: dts: add support for Laird WB45N cpu module and DVK

2018-06-15 Thread Nicolas Ferre
On 15/06/2018 at 12:01, Ben Whitten wrote: On 14/06/2018 at 10:51, Ben Whitten wrote: Signed-off-by: Ben Whitten --- arch/arm/boot/dts/Makefile| 3 +- arch/arm/boot/dts/at91-wb45n.dts | 66 +++ arch/arm/boot/dts/at91-wb45n.dtsi | 169 +

RE: [PATCH 1/4] arm: dts: add support for Laird WB45N cpu module and DVK

2018-06-15 Thread Ben Whitten
> On 14/06/2018 at 10:51, Ben Whitten wrote: > > Signed-off-by: Ben Whitten > > --- > > arch/arm/boot/dts/Makefile| 3 +- > > arch/arm/boot/dts/at91-wb45n.dts | 66 +++ > > arch/arm/boot/dts/at91-wb45n.dtsi | 169 > ++ > > 3 files ch

Re: [PATCH 1/4] arm: dts: add support for Laird WB45N cpu module and DVK

2018-06-14 Thread Alexandre Belloni
On 14/06/2018 14:52:25+0200, Nicolas Ferre wrote: > > + gpio_keys { > > + compatible = "gpio-keys"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + irqbtn@pb18 { > > I'm not sure that the @pb18 can be used like this. This address extension > mus

Re: [PATCH 1/4] arm: dts: add support for Laird WB45N cpu module and DVK

2018-06-14 Thread Nicolas Ferre
On 14/06/2018 at 10:51, Ben Whitten wrote: Signed-off-by: Ben Whitten --- arch/arm/boot/dts/Makefile| 3 +- arch/arm/boot/dts/at91-wb45n.dts | 66 +++ arch/arm/boot/dts/at91-wb45n.dtsi | 169 ++ 3 files changed, 237 insertions(+),

Re: [PATCH 1/4] arm: dts: add support for Laird WB45N cpu module and DVK

2018-06-14 Thread Alexandre Belloni
On 14/06/2018 11:07:33+0200, Alexandre Belloni wrote: > Hi, > > On 14/06/2018 09:51:54+0100, Ben Whitten wrote: > > This need a proper commit message. Maybe you can also add a link to the > technical brief for the platform? > > > Signed-off-by: Ben Whitten > > --- > > arch/arm/boot/dts/Makefil

Re: [PATCH 1/4] arm: dts: add support for Laird WB45N cpu module and DVK

2018-06-14 Thread Alexandre Belloni
Hi, On 14/06/2018 09:51:54+0100, Ben Whitten wrote: This need a proper commit message. Maybe you can also add a link to the technical brief for the platform? > Signed-off-by: Ben Whitten > --- > arch/arm/boot/dts/Makefile| 3 +- > arch/arm/boot/dts/at91-wb45n.dts | 66 +

[PATCH 1/4] arm: dts: add support for Laird WB45N cpu module and DVK

2018-06-14 Thread Ben Whitten
Signed-off-by: Ben Whitten --- arch/arm/boot/dts/Makefile| 3 +- arch/arm/boot/dts/at91-wb45n.dts | 66 +++ arch/arm/boot/dts/at91-wb45n.dtsi | 169 ++ 3 files changed, 237 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/d