Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-24 Thread Manivannan Sadhasivam
On 19 October 2017 at 02:27, Amit Kucheria wrote: > Enable panic and disk activity triggers to tie to LED activity > > Signed-off-by: Amit Kucheria Acked-by: Manivannan Sadhasivam Regards, Mani > --- >

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-24 Thread Manivannan Sadhasivam
On 19 October 2017 at 02:27, Amit Kucheria wrote: > Enable panic and disk activity triggers to tie to LED activity > > Signed-off-by: Amit Kucheria Acked-by: Manivannan Sadhasivam Regards, Mani > --- > arch/arm64/configs/defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-23 Thread Timur Tabi
On 10/23/17 6:11 PM, Amit Kucheria wrote: This is great, thanks. Can I take this as an ACK? Sure, but I'm not a maintainer for the defconfig, so it's just my personal opinion. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies,

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-23 Thread Timur Tabi
On 10/23/17 6:11 PM, Amit Kucheria wrote: This is great, thanks. Can I take this as an ACK? Sure, but I'm not a maintainer for the defconfig, so it's just my personal opinion. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies,

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-23 Thread Amit Kucheria
On Mon, Oct 23, 2017 at 8:54 PM, Timur Tabi wrote: > On 10/22/2017 11:56 PM, Amit Kucheria wrote: >> >> >> "Most development boards and devices have one or more LEDs. It is >> useful during debugging if they can be wired to show different >> behaviours such as disk or cpu

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-23 Thread Amit Kucheria
On Mon, Oct 23, 2017 at 8:54 PM, Timur Tabi wrote: > On 10/22/2017 11:56 PM, Amit Kucheria wrote: >> >> >> "Most development boards and devices have one or more LEDs. It is >> useful during debugging if they can be wired to show different >> behaviours such as disk or cpu activity or a

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-23 Thread Timur Tabi
On 10/22/2017 11:56 PM, Amit Kucheria wrote: "Most development boards and devices have one or more LEDs. It is useful during debugging if they can be wired to show different behaviours such as disk or cpu activity or a load-average dependent heartbeat. Enable panic and disk activity triggers so

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-23 Thread Timur Tabi
On 10/22/2017 11:56 PM, Amit Kucheria wrote: "Most development boards and devices have one or more LEDs. It is useful during debugging if they can be wired to show different behaviours such as disk or cpu activity or a load-average dependent heartbeat. Enable panic and disk activity triggers so

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-22 Thread Amit Kucheria
On Thu, Oct 19, 2017 at 8:54 PM, Timur Tabi wrote: > On 10/18/17 3:57 PM, Amit Kucheria wrote: >> >> Enable panic and disk activity triggers to tie to LED activity > > > Could you provide some explanation as to why we want this enabled for ARM64? > I don't have a problem

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-22 Thread Amit Kucheria
On Thu, Oct 19, 2017 at 8:54 PM, Timur Tabi wrote: > On 10/18/17 3:57 PM, Amit Kucheria wrote: >> >> Enable panic and disk activity triggers to tie to LED activity > > > Could you provide some explanation as to why we want this enabled for ARM64? > I don't have a problem with the change itself,

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-19 Thread Timur Tabi
On 10/18/17 3:57 PM, Amit Kucheria wrote: Enable panic and disk activity triggers to tie to LED activity Could you provide some explanation as to why we want this enabled for ARM64? I don't have a problem with the change itself, but I think patch descriptions for defconfig changes should

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-19 Thread Timur Tabi
On 10/18/17 3:57 PM, Amit Kucheria wrote: Enable panic and disk activity triggers to tie to LED activity Could you provide some explanation as to why we want this enabled for ARM64? I don't have a problem with the change itself, but I think patch descriptions for defconfig changes should

[PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-18 Thread Amit Kucheria
Enable panic and disk activity triggers to tie to LED activity Signed-off-by: Amit Kucheria --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 34480e9..4ed357f 100644

[PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-18 Thread Amit Kucheria
Enable panic and disk activity triggers to tie to LED activity Signed-off-by: Amit Kucheria --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 34480e9..4ed357f 100644 ---