Re: [PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-25 Thread Marc Zyngier
On Fri, 22 May 2015 23:57:40 +0100 "Chalamarla, Tirumalesh" wrote: Hi Tirumalesh, > > > On May 22, 2015, at 1:26 AM, Marc Zyngier wrote: > > > > On 20/05/15 13:48, Robert Richter wrote: > >> Mark, > >> > >> thanks for review, also of the other patches of this series. > >> > >> See below >

Re: [PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-25 Thread Marc Zyngier
On Fri, 22 May 2015 23:57:40 +0100 Chalamarla, Tirumalesh tirumalesh.chalama...@caviumnetworks.com wrote: Hi Tirumalesh, On May 22, 2015, at 1:26 AM, Marc Zyngier marc.zyng...@arm.com wrote: On 20/05/15 13:48, Robert Richter wrote: Mark, thanks for review, also of the other

Re: [PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-22 Thread Chalamarla, Tirumalesh
> On May 22, 2015, at 1:26 AM, Marc Zyngier wrote: > > On 20/05/15 13:48, Robert Richter wrote: >> Mark, >> >> thanks for review, also of the other patches of this series. >> >> See below >> >> On 20.05.15 13:11:38, Marc Zyngier wrote: - dev_alias->dev_id = alias; +

Re: [PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-22 Thread Marc Zyngier
On 20/05/15 13:48, Robert Richter wrote: > Mark, > > thanks for review, also of the other patches of this series. > > See below > > On 20.05.15 13:11:38, Marc Zyngier wrote: >>> - dev_alias->dev_id = alias; >>> + dev_alias->dev_id = (pci_domain_nr(pdev->bus) << 16) | alias; > >> This feels

Re: [PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-22 Thread Marc Zyngier
On 20/05/15 13:48, Robert Richter wrote: Mark, thanks for review, also of the other patches of this series. See below On 20.05.15 13:11:38, Marc Zyngier wrote: - dev_alias-dev_id = alias; + dev_alias-dev_id = (pci_domain_nr(pdev-bus) 16) | alias; This feels very scary. We're

Re: [PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-22 Thread Chalamarla, Tirumalesh
On May 22, 2015, at 1:26 AM, Marc Zyngier marc.zyng...@arm.com wrote: On 20/05/15 13:48, Robert Richter wrote: Mark, thanks for review, also of the other patches of this series. See below On 20.05.15 13:11:38, Marc Zyngier wrote: - dev_alias-dev_id = alias; + dev_alias-dev_id =

Re: [PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-20 Thread Robert Richter
Mark, thanks for review, also of the other patches of this series. See below On 20.05.15 13:11:38, Marc Zyngier wrote: > > - dev_alias->dev_id = alias; > > + dev_alias->dev_id = (pci_domain_nr(pdev->bus) << 16) | alias; > This feels very scary. We're now assuming that the domain number

Re: [PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-20 Thread Marc Zyngier
On Sun, 3 May 2015 21:49:29 +0100 Robert Richter wrote: > From: Tirumalesh Chalamarla > > PCI stream ids need to consider pci bridge number to be unique on the > system. Using only bus and devfn can't do the trick in systems that > have multiple pci bridges. > > Signed-off-by: Tirumalesh

Re: [PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-20 Thread Marc Zyngier
On Sun, 3 May 2015 21:49:29 +0100 Robert Richter r...@kernel.org wrote: From: Tirumalesh Chalamarla tchalama...@cavium.com PCI stream ids need to consider pci bridge number to be unique on the system. Using only bus and devfn can't do the trick in systems that have multiple pci bridges.

Re: [PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-20 Thread Robert Richter
Mark, thanks for review, also of the other patches of this series. See below On 20.05.15 13:11:38, Marc Zyngier wrote: - dev_alias-dev_id = alias; + dev_alias-dev_id = (pci_domain_nr(pdev-bus) 16) | alias; This feels very scary. We're now assuming that the domain number will always

[PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-03 Thread Robert Richter
From: Tirumalesh Chalamarla PCI stream ids need to consider pci bridge number to be unique on the system. Using only bus and devfn can't do the trick in systems that have multiple pci bridges. Signed-off-by: Tirumalesh Chalamarla Signed-off-by: Robert Richter ---

[PATCH 1/4] arm64: gicv3: its: Encode domain number in PCI stream id

2015-05-03 Thread Robert Richter
From: Tirumalesh Chalamarla tchalama...@cavium.com PCI stream ids need to consider pci bridge number to be unique on the system. Using only bus and devfn can't do the trick in systems that have multiple pci bridges. Signed-off-by: Tirumalesh Chalamarla tchalama...@cavium.com Signed-off-by: