Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Mika Westerberg
On Wed, Oct 10, 2012 at 04:42:00PM +0300, Felipe Balbi wrote: > Hi, > > On Wed, Oct 10, 2012 at 03:52:40PM +0300, Andy Shevchenko wrote: > > On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi wrote: > > > On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: > > >> On Wed, Oct 10, 2012 at

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 04:42:00PM +0300, Felipe Balbi wrote: > On Wed, Oct 10, 2012 at 03:52:40PM +0300, Andy Shevchenko wrote: > > On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi wrote: > > > On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: > > >> On Wed, Oct 10, 2012 at

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 03:52:40PM +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi wrote: > > On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: > >> On Wed, Oct 10, 2012 at 12:08 PM, viresh kumar > >> wrote: > >> > On Wed, Oct 10, 2012 at 2:34

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Andy Shevchenko
On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi wrote: > On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: >> On Wed, Oct 10, 2012 at 12:08 PM, viresh kumar >> wrote: >> > On Wed, Oct 10, 2012 at 2:34 PM, Andy Shevchenko >> > wrote: >> >> On Tue, 2012-10-02 at 14:41 +0300, Andy

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Felipe Balbi
On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2012 at 12:08 PM, viresh kumar > wrote: > > On Wed, Oct 10, 2012 at 2:34 PM, Andy Shevchenko > > wrote: > >> On Tue, 2012-10-02 at 14:41 +0300, Andy Shevchenko wrote: > >>> From: Heikki Krogerus > >>> > >>>

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Viresh Kumar
On 10 October 2012 14:51, Andy Shevchenko wrote: > We have spi, i2c and hsuart devices connected to the DMA controller. > In case we would like to use DMA we have to have the dw_dmac loaded > before them. Currently we have spi driver on subsys_initcall level, > and Mika, who is developing it,

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Andy Shevchenko
On Wed, Oct 10, 2012 at 12:08 PM, viresh kumar wrote: > On Wed, Oct 10, 2012 at 2:34 PM, Andy Shevchenko > wrote: >> On Tue, 2012-10-02 at 14:41 +0300, Andy Shevchenko wrote: >>> From: Heikki Krogerus >>> >>> Since v3.2 we have nice macro to define the platform driver's init and exit >>> calls.

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread viresh kumar
On Wed, Oct 10, 2012 at 2:34 PM, Andy Shevchenko wrote: > On Tue, 2012-10-02 at 14:41 +0300, Andy Shevchenko wrote: >> From: Heikki Krogerus >> >> Since v3.2 we have nice macro to define the platform driver's init and exit >> calls. This patch simplifies the dw_dmac driver by using that macro. >

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Andy Shevchenko
On Tue, 2012-10-02 at 14:41 +0300, Andy Shevchenko wrote: > From: Heikki Krogerus > > Since v3.2 we have nice macro to define the platform driver's init and exit > calls. This patch simplifies the dw_dmac driver by using that macro. Actually we can't do this. It will break initialization of

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Andy Shevchenko
On Tue, 2012-10-02 at 14:41 +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com Since v3.2 we have nice macro to define the platform driver's init and exit calls. This patch simplifies the dw_dmac driver by using that macro. Actually we can't do this. It will

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread viresh kumar
On Wed, Oct 10, 2012 at 2:34 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Tue, 2012-10-02 at 14:41 +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com Since v3.2 we have nice macro to define the platform driver's init and exit calls. This

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Andy Shevchenko
On Wed, Oct 10, 2012 at 12:08 PM, viresh kumar viresh.ku...@linaro.org wrote: On Wed, Oct 10, 2012 at 2:34 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Tue, 2012-10-02 at 14:41 +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com Since v3.2

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Viresh Kumar
On 10 October 2012 14:51, Andy Shevchenko andy.shevche...@gmail.com wrote: We have spi, i2c and hsuart devices connected to the DMA controller. In case we would like to use DMA we have to have the dw_dmac loaded before them. Currently we have spi driver on subsys_initcall level, and Mika, who

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Felipe Balbi
On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 12:08 PM, viresh kumar viresh.ku...@linaro.org wrote: On Wed, Oct 10, 2012 at 2:34 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Tue, 2012-10-02 at 14:41 +0300, Andy Shevchenko

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Andy Shevchenko
On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 12:08 PM, viresh kumar viresh.ku...@linaro.org wrote: On Wed, Oct 10, 2012 at 2:34 PM, Andy Shevchenko

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 03:52:40PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 12:08 PM, viresh kumar viresh.ku...@linaro.org wrote: On Wed,

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 04:42:00PM +0300, Felipe Balbi wrote: On Wed, Oct 10, 2012 at 03:52:40PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Mika Westerberg
On Wed, Oct 10, 2012 at 04:42:00PM +0300, Felipe Balbi wrote: Hi, On Wed, Oct 10, 2012 at 03:52:40PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at

[PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-02 Thread Andy Shevchenko
From: Heikki Krogerus Since v3.2 we have nice macro to define the platform driver's init and exit calls. This patch simplifies the dw_dmac driver by using that macro. Signed-off-by: Heikki Krogerus Signed-off-by: Andy Shevchenko Reviewed-by: Felipe Balbi Acked-by: Viresh Kumar ---

[PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-02 Thread Andy Shevchenko
From: Heikki Krogerus heikki.kroge...@linux.intel.com Since v3.2 we have nice macro to define the platform driver's init and exit calls. This patch simplifies the dw_dmac driver by using that macro. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko