RE: [PATCH 1/4] driver: add TXT driver in kernel

2013-05-09 Thread Ren, Qiaowei
On 2013-05-08, Matthew Garrett wrote: > On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: > > > + * This module is expected to be a better tool to access below > > + resources > > Expected to be or is? :) "is" :) > > + * Data is currently found below > > You're adding it to ABI, so it

RE: [PATCH 1/4] driver: add TXT driver in kernel

2013-05-09 Thread Ren, Qiaowei
On 2013-05-08, Matthew Garrett wrote: On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: + * This module is expected to be a better tool to access below + resources Expected to be or is? :) is :) + * Data is currently found below You're adding it to ABI, so it shouldn't just be

Re: [PATCH 1/4] driver: add TXT driver in kernel

2013-05-07 Thread Matthew Garrett
On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: > TXT driver is expected to be a better tool to access below resources: > TXT config space, TXT log and SMX parameter. Please explain what these things are in the commit log, the config help and the comment at the top of the driver - it'll

[PATCH 1/4] driver: add TXT driver in kernel

2013-05-07 Thread Qiaowei Ren
TXT driver is expected to be a better tool to access below resources: TXT config space, TXT log and SMX parameter. Signed-off-by: Qiaowei Ren Signed-off-by: Xiaoyan Zhang Signed-off-by: Gang Wei --- drivers/platform/x86/Kconfig |2 ++ drivers/platform/x86/Makefile

Re: [PATCH 1/4] driver: add TXT driver in kernel

2013-05-07 Thread Matthew Garrett
On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: TXT driver is expected to be a better tool to access below resources: TXT config space, TXT log and SMX parameter. Please explain what these things are in the commit log, the config help and the comment at the top of the driver - it'll make