Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-24 Thread Yicong Yang
On 2021/2/10 19:42, Daniel Thompson wrote: > On Mon, Feb 08, 2021 at 09:09:20PM +0800, Yicong Yang wrote: >> On 2021/2/8 18:47, Greg KH wrote: >>> On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: On 2021/2/5 17:53, Greg KH wrote: > What does this offer in benefit of the existin

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-10 Thread Daniel Thompson
On Mon, Feb 08, 2021 at 09:09:20PM +0800, Yicong Yang wrote: > On 2021/2/8 18:47, Greg KH wrote: > > On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: > >> On 2021/2/5 17:53, Greg KH wrote: > >>> What does this offer in benefit of the existing way? What is it fixing? > >>> Why do this "

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Yicong Yang
On 2021/2/8 18:47, Greg KH wrote: > On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: >> Hi Greg, >> >> On 2021/2/5 17:53, Greg KH wrote: >>> On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: From: Junhao He Use subdir-ccflags-* instead of ccflags-* to inherit

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: > Hi Greg, > > On 2021/2/5 17:53, Greg KH wrote: > > On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: > >> From: Junhao He > >> > >> Use subdir-ccflags-* instead of ccflags-* to inherit the debug > >> settings from Kconfig w

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Yicong Yang
Hi Greg, On 2021/2/5 17:53, Greg KH wrote: > On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: >> From: Junhao He >> >> Use subdir-ccflags-* instead of ccflags-* to inherit the debug >> settings from Kconfig when traversing subdirectories. > > That says what you do, but not _why_ you

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: > From: Junhao He > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > settings from Kconfig when traversing subdirectories. That says what you do, but not _why_ you are doing it. What does this offer in benefit of the

[PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Yicong Yang
From: Junhao He Use subdir-ccflags-* instead of ccflags-* to inherit the debug settings from Kconfig when traversing subdirectories. Suggested-by: Bjorn Helgaas Signed-off-by: Junhao He Signed-off-by: Yicong Yang --- drivers/base/Makefile | 2 +- drivers/base/power/Makefile | 2 -- 2 f