Re: [PATCH 1/4] drivers/misc/sgi-gru: remove unused variable

2015-09-03 Thread Dimitri Sivanich
On Thu, Sep 03, 2015 at 10:10:12AM +0530, Sudip Mukherjee wrote: > On Wed, Sep 02, 2015 at 09:42:04AM -0500, Dimitri Sivanich wrote: > > On Wed, Sep 02, 2015 at 04:54:55PM +0530, Sudip Mukherjee wrote: > > > These variables were only assigned some value and were never used. > > > > > > Signed-off-

Re: [PATCH 1/4] drivers/misc/sgi-gru: remove unused variable

2015-09-02 Thread Sudip Mukherjee
On Wed, Sep 02, 2015 at 09:42:04AM -0500, Dimitri Sivanich wrote: > On Wed, Sep 02, 2015 at 04:54:55PM +0530, Sudip Mukherjee wrote: > > These variables were only assigned some value and were never used. > > > > Signed-off-by: Sudip Mukherjee > > --- > > > > + int i; > + > + if ((GRU_NUM_

Re: [PATCH 1/4] drivers/misc/sgi-gru: remove unused variable

2015-09-02 Thread Dimitri Sivanich
On Wed, Sep 02, 2015 at 04:54:55PM +0530, Sudip Mukherjee wrote: > These variables were only assigned some value and were never used. > > Signed-off-by: Sudip Mukherjee > --- > > I have removed the variables in the functions gru_dump_tfm() and > gru_dump_tgh() but it appeared that the intended l

[PATCH 1/4] drivers/misc/sgi-gru: remove unused variable

2015-09-02 Thread Sudip Mukherjee
These variables were only assigned some value and were never used. Signed-off-by: Sudip Mukherjee --- I have removed the variables in the functions gru_dump_tfm() and gru_dump_tgh() but it appeared that the intended logic might have been something like: bytes = GRU_NUM_TFM * GRU_CACHE_LINE_BYTES