Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

Hi Masami, On Mon, Apr 17, 2017 at 8:52 PM, Masami Hiramatsu wrote: > On Mon, 17 Apr 2017 11:44:27 +0900 > Namhyung Kim wrote: > >> When function tracer has a pid filter, it adds a probe to sched_switch >> to track if current task can be ignored. The

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

Hi Masami, On Mon, Apr 17, 2017 at 8:52 PM, Masami Hiramatsu wrote: > On Mon, 17 Apr 2017 11:44:27 +0900 > Namhyung Kim wrote: > >> When function tracer has a pid filter, it adds a probe to sched_switch >> to track if current task can be ignored. The probe checks the >> ftrace_ignore_pid from

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Mon, 17 Apr 2017 11:44:27 +0900 Namhyung Kim wrote: > When function tracer has a pid filter, it adds a probe to sched_switch > to track if current task can be ignored. The probe checks the > ftrace_ignore_pid from current tr to filter tasks. But it misses to > delete

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Mon, 17 Apr 2017 11:44:27 +0900 Namhyung Kim wrote: > When function tracer has a pid filter, it adds a probe to sched_switch > to track if current task can be ignored. The probe checks the > ftrace_ignore_pid from current tr to filter tasks. But it misses to > delete the probe when removing

[PATCH 1/4] ftrace: Fix function pid filter on instances

When function tracer has a pid filter, it adds a probe to sched_switch to track if current task can be ignored. The probe checks the ftrace_ignore_pid from current tr to filter tasks. But it misses to delete the probe when removing an instance so that it can cause a crash due to the invalid tr

[PATCH 1/4] ftrace: Fix function pid filter on instances

When function tracer has a pid filter, it adds a probe to sched_switch to track if current task can be ignored. The probe checks the ftrace_ignore_pid from current tr to filter tasks. But it misses to delete the probe when removing an instance so that it can cause a crash due to the invalid tr

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Tue, Mar 28, 2017 at 10:58:43PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 11:42:27 +0900 > Namhyung Kim wrote: > > > On Tue, Mar 28, 2017 at 10:28:55PM -0400, Steven Rostedt wrote: > > > On Wed, 29 Mar 2017 11:20:37 +0900 > > > Namhyung Kim

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Tue, Mar 28, 2017 at 10:58:43PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 11:42:27 +0900 > Namhyung Kim wrote: > > > On Tue, Mar 28, 2017 at 10:28:55PM -0400, Steven Rostedt wrote: > > > On Wed, 29 Mar 2017 11:20:37 +0900 > > > Namhyung Kim wrote: > > > > > > > > > > > Actually,

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Wed, 29 Mar 2017 11:42:27 +0900 Namhyung Kim wrote: > On Tue, Mar 28, 2017 at 10:28:55PM -0400, Steven Rostedt wrote: > > On Wed, 29 Mar 2017 11:20:37 +0900 > > Namhyung Kim wrote: > > > > > > > > Actually, if this is called after

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Wed, 29 Mar 2017 11:42:27 +0900 Namhyung Kim wrote: > On Tue, Mar 28, 2017 at 10:28:55PM -0400, Steven Rostedt wrote: > > On Wed, 29 Mar 2017 11:20:37 +0900 > > Namhyung Kim wrote: > > > > > > > > Actually, if this is called after event_trace_del_tracer(), the tr is > > > > already

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Tue, Mar 28, 2017 at 10:28:55PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 11:20:37 +0900 > Namhyung Kim wrote: > > > > > Actually, if this is called after event_trace_del_tracer(), the tr is > > > already invisible and nothing new should change. > > > > I

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Tue, Mar 28, 2017 at 10:28:55PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 11:20:37 +0900 > Namhyung Kim wrote: > > > > > Actually, if this is called after event_trace_del_tracer(), the tr is > > > already invisible and nothing new should change. > > > > I don't follow. After

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Wed, 29 Mar 2017 11:20:37 +0900 Namhyung Kim wrote: > > Actually, if this is called after event_trace_del_tracer(), the tr is > > already invisible and nothing new should change. > > I don't follow. After event_trace_del_tracer(), the tr is invisible > from the probe

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Wed, 29 Mar 2017 11:20:37 +0900 Namhyung Kim wrote: > > Actually, if this is called after event_trace_del_tracer(), the tr is > > already invisible and nothing new should change. > > I don't follow. After event_trace_del_tracer(), the tr is invisible > from the probe of event tracing but

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Tue, Mar 28, 2017 at 10:08:41PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 10:46:22 +0900 > Namhyung Kim wrote: > > > When function tracer has a pid filter, it adds a probe to sched_switch > > to track if current task can be ignored. The probe checks the > >

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Tue, Mar 28, 2017 at 10:08:41PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 10:46:22 +0900 > Namhyung Kim wrote: > > > When function tracer has a pid filter, it adds a probe to sched_switch > > to track if current task can be ignored. The probe checks the > > ftrace_ignore_pid from

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

Hi Steve, On Tue, Mar 28, 2017 at 10:08:41PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 10:46:22 +0900 > Namhyung Kim wrote: > > > When function tracer has a pid filter, it adds a probe to sched_switch > > to track if current task can be ignored. The probe checks

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

Hi Steve, On Tue, Mar 28, 2017 at 10:08:41PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 10:46:22 +0900 > Namhyung Kim wrote: > > > When function tracer has a pid filter, it adds a probe to sched_switch > > to track if current task can be ignored. The probe checks the > >

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Wed, 29 Mar 2017 10:46:22 +0900 Namhyung Kim wrote: > When function tracer has a pid filter, it adds a probe to sched_switch > to track if current task can be ignored. The probe checks the > ftrace_ignore_pid from current tr to filter tasks. But it misses to > delete

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

On Wed, 29 Mar 2017 10:46:22 +0900 Namhyung Kim wrote: > When function tracer has a pid filter, it adds a probe to sched_switch > to track if current task can be ignored. The probe checks the > ftrace_ignore_pid from current tr to filter tasks. But it misses to > delete the probe when removing

[PATCH 1/4] ftrace: Fix function pid filter on instances

When function tracer has a pid filter, it adds a probe to sched_switch to track if current task can be ignored. The probe checks the ftrace_ignore_pid from current tr to filter tasks. But it misses to delete the probe when removing an instance so that it can cause a crash due to the invalid tr

[PATCH 1/4] ftrace: Fix function pid filter on instances

When function tracer has a pid filter, it adds a probe to sched_switch to track if current task can be ignored. The probe checks the ftrace_ignore_pid from current tr to filter tasks. But it misses to delete the probe when removing an instance so that it can cause a crash due to the invalid tr