Re: [PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE

2013-10-02 Thread Martin Walch
On Wednesday 02 October 2013 16:42:27 David Rientjes wrote: > The purpose of SYMBOL_WRITE is in sym_calc_value() where it is set if the > config symbol is visible and settable by the user, which is why I > suggested it be specified as being writable by the user. Then this looks strange to me: a

Re: [PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE

2013-10-02 Thread David Rientjes
On Thu, 3 Oct 2013, Martin Walch wrote: > So, if I have not missed anything, SYMBOL_WRITE decides whether to write a > symbol > to .config or not. This does not necessarily mean that the user can change > the value. > SYMBOL_WRITE may be set and the symbol may be written to .config while the >

Re: [PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE

2013-10-02 Thread Martin Walch
> > diff --git a/scripts/kconfig/expr.h b/scripts/kconfig/expr.h > > index df198a5..ba663e1 100644 > > --- a/scripts/kconfig/expr.h > > +++ b/scripts/kconfig/expr.h > > @@ -93,7 +93,7 @@ struct symbol { > > #define SYMBOL_CHOICEVAL 0x0020 /* used as a value in a choice block */ > > #define SYMB

Re: [PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE

2013-10-01 Thread David Rientjes
On Wed, 2 Oct 2013, Martin Walch wrote: > diff --git a/scripts/kconfig/expr.h b/scripts/kconfig/expr.h > index df198a5..ba663e1 100644 > --- a/scripts/kconfig/expr.h > +++ b/scripts/kconfig/expr.h > @@ -93,7 +93,7 @@ struct symbol { > #define SYMBOL_CHOICEVAL 0x0020 /* used as a value in a choi

[PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE

2013-10-01 Thread Martin Walch
From: Martin Walch Date: Wed, 2 Oct 2013 06:54:27 +0200 Subject: [PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE replace the question mark in the comment after SYMBOL_WRITE with an explanation Signed-off-by: Martin Walch --- scripts/kconfig/expr.h | 2 +- 1 file changed, 1 insertion