Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2018-01-24 Thread J. Bruce Fields
On Tue, Jan 23, 2018 at 07:47:31PM -0500, Trond Myklebust wrote: > Sorry I forgot about the issues with the server garbage collector, and > I applied these patches to my linux-next a couple of weeks ago. Whoops, OK, so who's taking those patches anyway? > What say we fix the issue with something

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2018-01-24 Thread J. Bruce Fields
On Tue, Jan 23, 2018 at 07:47:31PM -0500, Trond Myklebust wrote: > Sorry I forgot about the issues with the server garbage collector, and > I applied these patches to my linux-next a couple of weeks ago. Whoops, OK, so who's taking those patches anyway? > What say we fix the issue with something

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2018-01-23 Thread Trond Myklebust
On Tue, 2018-01-23 at 17:09 -0500, J. Bruce Fields wrote: > > The object still has useful information in it so we can't just > reinitalize it completely. I guess we could make nlm_get_host do > > if (refcount_read(>h_count)) > refcount_inc(>h_count); > else >

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2018-01-23 Thread Trond Myklebust
On Tue, 2018-01-23 at 17:09 -0500, J. Bruce Fields wrote: > > The object still has useful information in it so we can't just > reinitalize it completely. I guess we could make nlm_get_host do > > if (refcount_read(>h_count)) > refcount_inc(>h_count); > else >

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2018-01-23 Thread J. Bruce Fields
On Wed, Dec 27, 2017 at 12:10:15PM +, Reshetova, Elena wrote: > > On Fri, Dec 22, 2017 at 09:25:53AM -0500, J. Bruce Fields wrote: > > > On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > > > > > > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > > > >

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2018-01-23 Thread J. Bruce Fields
On Wed, Dec 27, 2017 at 12:10:15PM +, Reshetova, Elena wrote: > > On Fri, Dec 22, 2017 at 09:25:53AM -0500, J. Bruce Fields wrote: > > > On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > > > > > > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > > > >

RE: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-12-27 Thread Reshetova, Elena
> On Fri, Dec 22, 2017 at 09:25:53AM -0500, J. Bruce Fields wrote: > > On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > > > > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > > > atomic_t variables are currently used to implement reference > > > >

RE: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-12-27 Thread Reshetova, Elena
> On Fri, Dec 22, 2017 at 09:25:53AM -0500, J. Bruce Fields wrote: > > On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > > > > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > > > atomic_t variables are currently used to implement reference > > > >

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-12-22 Thread J. Bruce Fields
On Fri, Dec 22, 2017 at 09:25:53AM -0500, J. Bruce Fields wrote: > On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > > atomic_t variables are currently used to implement reference > > > counters with the

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-12-22 Thread J. Bruce Fields
On Fri, Dec 22, 2017 at 09:25:53AM -0500, J. Bruce Fields wrote: > On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > > atomic_t variables are currently used to implement reference > > > counters with the

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-12-22 Thread J. Bruce Fields
On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > atomic_t variables are currently used to implement reference > > counters with the following properties: > > - counter is initialized to 1 using atomic_set()

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-12-22 Thread J. Bruce Fields
On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > atomic_t variables are currently used to implement reference > > counters with the following properties: > > - counter is initialized to 1 using atomic_set()

RE: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-12-22 Thread Reshetova, Elena
On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > atomic_t variables are currently used to implement reference > counters with the following properties: > - counter is initialized to 1 using atomic_set() > - a resource is freed upon counter reaching zero > - once counter

RE: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-12-22 Thread Reshetova, Elena
On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > atomic_t variables are currently used to implement reference > counters with the following properties: > - counter is initialized to 1 using atomic_set() > - a resource is freed upon counter reaching zero > - once counter

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-12-21 Thread J. Bruce Fields
On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > atomic_t variables are currently used to implement reference > counters with the following properties: > - counter is initialized to 1 using atomic_set() > - a resource is freed upon counter reaching zero > - once counter

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-12-21 Thread J. Bruce Fields
On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > atomic_t variables are currently used to implement reference > counters with the following properties: > - counter is initialized to 1 using atomic_set() > - a resource is freed upon counter reaching zero > - once counter

[PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-11-29 Thread Elena Reshetova
atomic_t variables are currently used to implement reference counters with the following properties: - counter is initialized to 1 using atomic_set() - a resource is freed upon counter reaching zero - once counter reaches zero, its further increments aren't allowed - counter schema uses

[PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

2017-11-29 Thread Elena Reshetova
atomic_t variables are currently used to implement reference counters with the following properties: - counter is initialized to 1 using atomic_set() - a resource is freed upon counter reaching zero - once counter reaches zero, its further increments aren't allowed - counter schema uses