Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-20 Thread Johannes Berg
On Thu, 2014-10-16 at 19:20 +0200, Rostislav Lisovy wrote: > Now I realized it is not that easy (and I confused "interface running" > and being "connected to the network"). There seems not to be a solid > indication that we are no longer "connected" to the network. Oops, ignore my previous reply.

Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-20 Thread Johannes Berg
On Thu, 2014-10-16 at 18:33 +0200, Rostislav Lisovy wrote: > You are right. I hope the following is a reasonable solution (in form of > a patch to my previous patch; comment stolen from some prehistoric > version of mesh.c): > > @@ -127,6 +127,9 @@ void ieee80211_ocb_work(struct ieee80211_sub_if_

Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-16 Thread Rostislav Lisovy
On Thu, 2014-10-16 at 18:33 +0200, Rostislav Lisovy wrote: > > > + mutex_lock(&sdata->local->mtx); > > > + ieee80211_vif_release_channel(sdata); > > > + mutex_unlock(&sdata->local->mtx); > > > + > > > + skb_queue_purge(&sdata->skb_queue); > > > + > > > + del_timer_sync(&sdata->u.ocb.house

Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-16 Thread Rostislav Lisovy
Hello Johannes; Thanks for the thorough review. On Thu, 2014-10-09 at 10:23 +0200, Johannes Berg wrote: > On Thu, 2014-09-11 at 16:30 +0200, Rostislav Lisovy wrote: > > +++ b/net/mac80211/cfg.c > > @@ -229,6 +229,7 @@ static int ieee80211_add_key(struct wiphy *wiphy, > > struct net_device *dev, >

Re: [PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-10-09 Thread Johannes Berg
On Thu, 2014-09-11 at 16:30 +0200, Rostislav Lisovy wrote: [...] Nice work. Let me (finally) look in more detail ... > +++ b/include/uapi/linux/nl80211.h > @@ -2031,6 +2031,8 @@ enum nl80211_attrs { > * and therefore can't be created in the normal ways, use the > * %NL80211_CMD_START_P2

[PATCH 1/4] mac80211: OCB mode + join and leave handling

2014-09-11 Thread Rostislav Lisovy
All the devices compliant to the IEEE 802.11p (dot11OCBActivated=true) should operate in the OCB (Outside the Context of a BSS) mode. This makes it possible to communicate without the need for association/authentication. All participants use the wildcard BSSID (set to all 1's). In OCB mode there a