Re: [PATCH 1/4] mm, rmap: do easy-job first in anon_vma_fork

2013-08-07 Thread Joonsoo Kim
Hello, Johannes. On Tue, Aug 06, 2013 at 08:58:54AM -0400, Johannes Weiner wrote: > > if (anon_vma_clone(vma, pvma)) > > - return -ENOMEM; > > - > > - /* Then add our own anon_vma. */ > > - anon_vma = anon_vma_alloc(); > > - if (!anon_vma) > > - goto out_error; > > -

Re: [PATCH 1/4] mm, rmap: do easy-job first in anon_vma_fork

2013-08-07 Thread Joonsoo Kim
Hello, Johannes. On Tue, Aug 06, 2013 at 08:58:54AM -0400, Johannes Weiner wrote: if (anon_vma_clone(vma, pvma)) - return -ENOMEM; - - /* Then add our own anon_vma. */ - anon_vma = anon_vma_alloc(); - if (!anon_vma) - goto out_error; - avc =

Re: [PATCH 1/4] mm, rmap: do easy-job first in anon_vma_fork

2013-08-06 Thread Johannes Weiner
On Tue, Aug 06, 2013 at 05:43:37PM +0900, Joonsoo Kim wrote: > If we fail due to some errorous situation, it is better to quit > without doing heavy work. So changing order of execution. > > Signed-off-by: Joonsoo Kim > > diff --git a/mm/rmap.c b/mm/rmap.c > index a149e3a..c2f51cb 100644 > ---

[PATCH 1/4] mm, rmap: do easy-job first in anon_vma_fork

2013-08-06 Thread Joonsoo Kim
If we fail due to some errorous situation, it is better to quit without doing heavy work. So changing order of execution. Signed-off-by: Joonsoo Kim diff --git a/mm/rmap.c b/mm/rmap.c index a149e3a..c2f51cb 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -278,19 +278,19 @@ int anon_vma_fork(struct

[PATCH 1/4] mm, rmap: do easy-job first in anon_vma_fork

2013-08-06 Thread Joonsoo Kim
If we fail due to some errorous situation, it is better to quit without doing heavy work. So changing order of execution. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/mm/rmap.c b/mm/rmap.c index a149e3a..c2f51cb 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -278,19 +278,19 @@ int

Re: [PATCH 1/4] mm, rmap: do easy-job first in anon_vma_fork

2013-08-06 Thread Johannes Weiner
On Tue, Aug 06, 2013 at 05:43:37PM +0900, Joonsoo Kim wrote: If we fail due to some errorous situation, it is better to quit without doing heavy work. So changing order of execution. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/mm/rmap.c b/mm/rmap.c index