Re: [PATCH 1/4] mtd: Add sysfs attr to expose ECC stats

2014-05-18 Thread Ezequiel Garcia
On 12 May 11:26 PM, Ezequiel Garcia wrote: > On 12 May 05:50 PM, Brian Norris wrote: > > > There are some guidelines about attributes in > > > 'Documentation/filesystems/sysfs.txt' > > > Though it's acceptable to put array of values of the "same type" in > > > single sysfs file, > > > But I'm sti

Re: [PATCH 1/4] mtd: Add sysfs attr to expose ECC stats

2014-05-13 Thread Ezequiel Garcia
On 13 May 01:15 PM, Greg Kroah-Hartman wrote: > On Mon, May 12, 2014 at 11:26:14PM -0300, Ezequiel Garcia wrote: > > On 12 May 05:50 PM, Brian Norris wrote: > > > > There are some guidelines about attributes in > > > > 'Documentation/filesystems/sysfs.txt' > > > > Though it's acceptable to put arr

Re: [PATCH 1/4] mtd: Add sysfs attr to expose ECC stats

2014-05-13 Thread Greg Kroah-Hartman
On Mon, May 12, 2014 at 11:26:14PM -0300, Ezequiel Garcia wrote: > On 12 May 05:50 PM, Brian Norris wrote: > > > There are some guidelines about attributes in > > > 'Documentation/filesystems/sysfs.txt' > > > Though it's acceptable to put array of values of the "same type" in > > > single sysfs f

Re: [PATCH 1/4] mtd: Add sysfs attr to expose ECC stats

2014-05-12 Thread Ezequiel Garcia
On 12 May 05:50 PM, Brian Norris wrote: > > There are some guidelines about attributes in > > 'Documentation/filesystems/sysfs.txt' > > Though it's acceptable to put array of values of the "same type" in single > > sysfs file, > > But I'm still not confident on having all members of 'struct ecc_s

Re: [PATCH 1/4] mtd: Add sysfs attr to expose ECC stats

2014-05-12 Thread Brian Norris
+ Greg KH, LKML For context: http://thread.gmane.org/gmane.linux.drivers.mtd/52517/focus=52518 On Tue, Apr 15, 2014 at 11:13:52AM +, Pekon Gupta wrote: > >From: Ezequiel Garcia > >>On Mar 27, Gupta, Pekon wrote: > >> > > >> >+static ssize_t mtd_ecc_stats_show(struct device *dev, > >> >+