Re: [PATCH 1/4] phy: qcom-qmp: Add SM8350 USB QMP PHYs

2021-01-15 Thread Jack Pham
Hi Vinod, On Fri, Jan 15, 2021 at 06:17:36PM +0530, Vinod Koul wrote: > On 15-01-21, 12:54, Konrad Dybcio wrote: > > I might be wrong but it looks as if you forgot to add a compatible > > for the "sm8350_usb3_uniphy_cfg" configuration. I believe Konrad was referring to the driver in which I had

Re: [PATCH 1/4] phy: qcom-qmp: Add SM8350 USB QMP PHYs

2021-01-15 Thread Jack Pham
On Fri, Jan 15, 2021 at 12:54:26PM +0100, Konrad Dybcio wrote: > I might be wrong but it looks as if you forgot to add a compatible for > the "sm8350_usb3_uniphy_cfg" configuration. Not wrong at all! My mistake, will add it in v2. Thanks, Jack -- The Qualcomm Innovation Center, Inc. is a member

Re: [PATCH 1/4] phy: qcom-qmp: Add SM8350 USB QMP PHYs

2021-01-15 Thread Vinod Koul
On 15-01-21, 12:54, Konrad Dybcio wrote: > Hi, > > > I might be wrong but it looks as if you forgot to add a compatible for the > "sm8350_usb3_uniphy_cfg" configuration. It seems to be documented in patch 2, ideally we should have the bindings patches first and this as patch 3... > > >

Re: [PATCH 1/4] phy: qcom-qmp: Add SM8350 USB QMP PHYs

2021-01-15 Thread Konrad Dybcio
Hi, I might be wrong but it looks as if you forgot to add a compatible for the "sm8350_usb3_uniphy_cfg" configuration. Konrad

[PATCH 1/4] phy: qcom-qmp: Add SM8350 USB QMP PHYs

2021-01-15 Thread Jack Pham
Add support for the USB DP & UNI PHYs found on SM8350. These use version 5.0.0 of the QMP PHY IP and thus require new "V5" definitions of the register offset macros for the QSERDES RX and TX blocks. The QSERDES common and QPHY PCS blocks' register offsets are largely unchanged from V4 so some of