Re: [PATCH 1/4] pinctrl: samsung: Fix device node refcount leaks in Exynos wakeup controller init

2019-08-06 Thread Krzysztof Kozlowski
On Tue, 6 Aug 2019 at 16:15, Linus Walleij wrote: > > On Mon, Aug 5, 2019 at 6:27 PM Krzysztof Kozlowski wrote: > > > In exynos_eint_wkup_init() the for_each_child_of_node() loop is used > > with a break to find a matching child node. Although each iteration of > > for_each_child_of_node puts

Re: [PATCH 1/4] pinctrl: samsung: Fix device node refcount leaks in Exynos wakeup controller init

2019-08-06 Thread Linus Walleij
On Mon, Aug 5, 2019 at 6:27 PM Krzysztof Kozlowski wrote: > In exynos_eint_wkup_init() the for_each_child_of_node() loop is used > with a break to find a matching child node. Although each iteration of > for_each_child_of_node puts the previous node, but early exit from loop > misses it. This

[PATCH 1/4] pinctrl: samsung: Fix device node refcount leaks in Exynos wakeup controller init

2019-08-05 Thread Krzysztof Kozlowski
In exynos_eint_wkup_init() the for_each_child_of_node() loop is used with a break to find a matching child node. Although each iteration of for_each_child_of_node puts the previous node, but early exit from loop misses it. This leads to leak of device node. Signed-off-by: Krzysztof Kozlowski