Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-08 Thread Andy Shevchenko
On Mon, Mar 8, 2021 at 3:02 PM Henning Schild wrote: > Am Fri, 5 Mar 2021 19:44:57 +0200 > schrieb Andy Shevchenko : > > On Fri, Mar 5, 2021 at 7:17 PM Andy Shevchenko > > wrote: > > > On Fri, Mar 5, 2021 at 6:47 PM Henning Schild > > > wrote: > > > > Am Fri, 5 Mar 2021 17:42:42 +0200 > > > > sc

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-08 Thread Henning Schild
Am Fri, 5 Mar 2021 19:44:57 +0200 schrieb Andy Shevchenko : > On Fri, Mar 5, 2021 at 7:17 PM Andy Shevchenko > wrote: > > > > On Fri, Mar 5, 2021 at 6:47 PM Henning Schild > > wrote: > > > Am Fri, 5 Mar 2021 17:42:42 +0200 > > > schrieb Andy Shevchenko : > > > > On Thu, Mar 4, 2021 at 3:47 P

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Andy Shevchenko
On Fri, Mar 5, 2021 at 7:17 PM Andy Shevchenko wrote: > > On Fri, Mar 5, 2021 at 6:47 PM Henning Schild > wrote: > > Am Fri, 5 Mar 2021 17:42:42 +0200 > > schrieb Andy Shevchenko : > > > On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede > > > wrote: > > ... > > > > [1]: https://gitlab.com/andy-shev/n

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Andy Shevchenko
On Fri, Mar 5, 2021 at 6:47 PM Henning Schild wrote: > Am Fri, 5 Mar 2021 17:42:42 +0200 > schrieb Andy Shevchenko : > > On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede > > wrote: ... > > [1]: https://gitlab.com/andy-shev/next/-/tree/p2sb > > That is a little weird, might be a good idea to RFC rep

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Henning Schild
Am Fri, 5 Mar 2021 17:42:42 +0200 schrieb Andy Shevchenko : > On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede > wrote: > > On 3/4/21 11:11 AM, Andy Shevchenko wrote: > > > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > > > wrote: > > ... > > > >> +u32 simatic_ipc_get_membase0(unsigned int p2

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Andy Shevchenko
On Fri, Mar 5, 2021 at 6:41 PM Andy Shevchenko wrote: > > On Fri, Mar 5, 2021 at 6:25 PM Andy Shevchenko > wrote: > > On Fri, Mar 5, 2021 at 6:14 PM Hans de Goede wrote: > > > On 3/5/21 4:42 PM, Andy Shevchenko wrote: > > ... > > > > So I took a quick look at the following 2 commits: > > > > (On

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Henning Schild
Am Fri, 5 Mar 2021 17:46:08 +0200 schrieb Andy Shevchenko : > On Thu, Mar 4, 2021 at 9:52 PM Henning Schild > wrote: > > Am Thu, 4 Mar 2021 12:11:12 +0200 > > schrieb Andy Shevchenko : > > > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > > > wrote: > > ... > > > > Check for the rest of th

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Andy Shevchenko
On Fri, Mar 5, 2021 at 6:25 PM Andy Shevchenko wrote: > On Fri, Mar 5, 2021 at 6:14 PM Hans de Goede wrote: > > On 3/5/21 4:42 PM, Andy Shevchenko wrote: ... > > So I took a quick look at the following 2 commits: > > (One of the latter commits moves the code to drivers/pci/pci-p2sb.c, > do you

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Hans de Goede
Hi, On 3/5/21 5:25 PM, Andy Shevchenko wrote: > On Fri, Mar 5, 2021 at 6:14 PM Hans de Goede wrote: >> On 3/5/21 4:42 PM, Andy Shevchenko wrote: >>> On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede wrote: On 3/4/21 11:11 AM, Andy Shevchenko wrote: > On Thu, Mar 4, 2021 at 8:36 AM Henning Sc

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Andy Shevchenko
On Fri, Mar 5, 2021 at 6:14 PM Hans de Goede wrote: > On 3/5/21 4:42 PM, Andy Shevchenko wrote: > > On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede wrote: > >> On 3/4/21 11:11 AM, Andy Shevchenko wrote: > >>> On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > >>> wrote: ... > >>> Oy vey! I know what

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Hans de Goede
Hi, On 3/5/21 4:42 PM, Andy Shevchenko wrote: > On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede wrote: >> On 3/4/21 11:11 AM, Andy Shevchenko wrote: >>> On Thu, Mar 4, 2021 at 8:36 AM Henning Schild >>> wrote: > > ... > +u32 simatic_ipc_get_membase0(unsigned int p2sb) +{ + u3

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Andy Shevchenko
On Thu, Mar 4, 2021 at 9:52 PM Henning Schild wrote: > Am Thu, 4 Mar 2021 12:11:12 +0200 > schrieb Andy Shevchenko : > > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > > wrote: ... > > Check for the rest of the series as well (basically this is the rule > > of thumb to recheck entire code for

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Andy Shevchenko
On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede wrote: > On 3/4/21 11:11 AM, Andy Shevchenko wrote: > > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > > wrote: ... > >> +u32 simatic_ipc_get_membase0(unsigned int p2sb) > >> +{ > >> + u32 bar0 = 0; > > > >> +#ifdef CONFIG_PCI > > > > It's ugl

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-04 Thread Henning Schild
Am Thu, 4 Mar 2021 12:11:12 +0200 schrieb Andy Shevchenko : > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > wrote: > > > > From: Henning Schild > > > > This mainly implements detection of these devices and will allow > > secondary drivers to work on such machines. > > > > The identification is

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-04 Thread Hans de Goede
Hi, On 3/2/21 5:33 PM, Henning Schild wrote: > +static inline u32 simatic_ipc_get_station_id(u8 *data) > +{ > + u32 station_id = SIMATIC_IPC_INVALID_STATION_ID; > + int i; > + struct { > + u8 type; /* type (0xff = binary) */ > + u8 len;

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-04 Thread Hans de Goede
Hi, On 3/4/21 11:11 AM, Andy Shevchenko wrote: > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > wrote: >> >> From: Henning Schild >> >> This mainly implements detection of these devices and will allow >> secondary drivers to work on such machines. >> >> The identification is DMI-based with a ve

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-04 Thread Andy Shevchenko
On Thu, Mar 4, 2021 at 8:36 AM Henning Schild wrote: > > From: Henning Schild > > This mainly implements detection of these devices and will allow > secondary drivers to work on such machines. > > The identification is DMI-based with a vendor specific way to tell them > apart in a reliable way. >

[PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-02 Thread Henning Schild
From: Henning Schild This mainly implements detection of these devices and will allow secondary drivers to work on such machines. The identification is DMI-based with a vendor specific way to tell them apart in a reliable way. Drivers for LEDs and Watchdogs will follow to make use of that platf