On Fri, Aug 17, 2018 at 02:36:01PM -0700, Bjorn Andersson wrote:
> FWIW, we've had this problem on other devices as well; where the eMMC
> won't operate properly unless the supply operates in HPM. We've worked
> around this by specifying regulator-system-load for said regulators.
You can set the
On Tue 14 Aug 10:06 PDT 2018, Douglas Anderson wrote:
> Not all regulator consumers call regulator_set_load(). On some
> regulators (like on RPMh-regulator) this could be bad since the
> regulator framework will treat this as if consumer needs no load.
> It's much better to assume that a dumb cli
Hi,
On Thu, Aug 16, 2018 at 1:58 PM, David Collins wrote:
> Hello Doug,
>
> On 08/16/2018 01:07 PM, Doug Anderson wrote:
>> I'll work on either adding more regulator_set_load() calls to clients
>> or perhaps disabling the "regulator-allow-set-load" for a bunch of
>> rails. David: presumably if w
Hello Doug,
On 08/16/2018 01:07 PM, Doug Anderson wrote:
> I'll work on either adding more regulator_set_load() calls to clients
> or perhaps disabling the "regulator-allow-set-load" for a bunch of
> rails. David: presumably if we have a rail that we never need to be
> on-and-in-low-power-mode ca
Hi,
On Wed, Aug 15, 2018 at 4:13 AM, Mark Brown wrote:
> On Tue, Aug 14, 2018 at 04:56:42PM -0700, Doug Anderson wrote:
>
>> IMO about the best we could hope to do would be to map "mode" from
>> children to parent. AKA: perhaps you could assume that if a child is
>> in a higher power mode that p
On Tue, Aug 14, 2018 at 04:56:42PM -0700, Doug Anderson wrote:
> IMO about the best we could hope to do would be to map "mode" from
> children to parent. AKA: perhaps you could assume that if a child is
> in a higher power mode that perhaps a parent should be too?
That's not going to work well -
On Tue, Aug 14, 2018 at 01:03:07PM -0700, Doug Anderson wrote:
> Specifically I will note that there are boatloads of drivers out there
> that use the regulator framework but don't have a call to
> regulator_set_load() in them. Are these drivers all broken? I don't
> think so. IMO the regulator
On Tue, Aug 14, 2018 at 10:06:14AM -0700, Douglas Anderson wrote:
> Not all regulator consumers call regulator_set_load(). On some
> regulators (like on RPMh-regulator) this could be bad since the
> regulator framework will treat this as if consumer needs no load.
> It's much better to assume that
On 08/14/2018 04:56 PM, Doug Anderson wrote:
> On Tue, Aug 14, 2018 at 2:59 PM, David Collins
> wrote:
>> On 08/14/2018 01:03 PM, Doug Anderson wrote:
>>> On Tue, Aug 14, 2018 at 11:30 AM, David Collins
>>> wrote:>>> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -
Hi,
On Tue, Aug 14, 2018 at 2:59 PM, David Collins wrote:
> Hi,
>
> On 08/14/2018 01:03 PM, Doug Anderson wrote:
>> On Tue, Aug 14, 2018 at 11:30 AM, David Collins
>> wrote:>>> --- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -732,6 +732,7 @@ static int drms_uA_update(
Hi,
On 08/14/2018 01:03 PM, Doug Anderson wrote:
> On Tue, Aug 14, 2018 at 11:30 AM, David Collins
> wrote:>>> --- a/drivers/regulator/core.c
>>> +++ b/drivers/regulator/core.c
>>> @@ -732,6 +732,7 @@ static int drms_uA_update(struct regulator_dev *rdev)
>>> struct regulator *sibling;
>>>
Hi,
On Tue, Aug 14, 2018 at 11:30 AM, David Collins wrote:
> The behavior introduced by this patch seems like an undesirable hack to
> me. It goes against the general philosophy within the regulator framework
> of taking no action unless directed to do so by an explicit consumer
> request (or sp
Hello Doug,
On 08/14/2018 10:06 AM, Douglas Anderson wrote:
> Not all regulator consumers call regulator_set_load(). On some
> regulators (like on RPMh-regulator) this could be bad since the
> regulator framework will treat this as if consumer needs no load.
> It's much better to assume that a du
Not all regulator consumers call regulator_set_load(). On some
regulators (like on RPMh-regulator) this could be bad since the
regulator framework will treat this as if consumer needs no load.
It's much better to assume that a dumb client needs the maximum
possible load so we get correctness first
14 matches
Mail list logo