Re: [PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection

2024-07-01 Thread Mathieu Poirier
On Mon, Jul 01, 2024 at 04:13:00AM -0500, Hari Nagalla wrote: > On 6/28/24 14:58, Mathieu Poirier wrote: > > > This could lead in an incorrect IPC-only mode detection if reset line is > > > asserted (so reset_control_status() return > 0) and c_state != 0 and > > > halted == 0. > > > In this case,

Re: [PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection

2024-07-01 Thread Hari Nagalla
On 6/28/24 14:58, Mathieu Poirier wrote: This could lead in an incorrect IPC-only mode detection if reset line is asserted (so reset_control_status() return > 0) and c_state != 0 and halted == 0. In this case, the old code would have detected an IPC-only mode instead of a mismatched mode. Your

Re: [PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection

2024-06-28 Thread Mathieu Poirier
Nishanth, Vignesh, Hari and Andrew - please have a look at this patch. Thanks, Mathieu On Fri, 28 Jun 2024 at 13:53, Mathieu Poirier wrote: > > Good day, > > On Fri, Jun 21, 2024 at 05:00:55PM +0200, Richard Genoud wrote: > > ret variable was used to test reset status, get from > >

Re: [PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection

2024-06-28 Thread Mathieu Poirier
Good day, On Fri, Jun 21, 2024 at 05:00:55PM +0200, Richard Genoud wrote: > ret variable was used to test reset status, get from > reset_control_status() call. But this variable was overwritten by > ti_sci_proc_get_status() a few lines bellow. > And as ti_sci_proc_get_status() returns 0 or a

[PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection

2024-06-21 Thread Richard Genoud
ret variable was used to test reset status, get from reset_control_status() call. But this variable was overwritten by ti_sci_proc_get_status() a few lines bellow. And as ti_sci_proc_get_status() returns 0 or a negative value (in this latter case, followed by a return), the expression !ret was