Re: [PATCH 1/4] serial: sh-sci: Replace printk() by pr_*()

2014-03-12 Thread Simon Horman
On Tue, Mar 11, 2014 at 11:30:52AM +0100, Laurent Pinchart wrote: > Hi Geert, > > Thank you for the patches. > > I had patches similar to 3/4 and 4/4 in my tree, that's a sign you're going > in > the right direction (or at least the direction I consider to be right :-)). > For the whole series

Re: [PATCH 1/4] serial: sh-sci: Replace printk() by pr_*()

2014-03-11 Thread Joe Perches
On Tue, 2014-03-11 at 11:11 +0100, Geert Uytterhoeven wrote: > From: Geert Uytterhoeven > > Make banner const while we're at it One thing to consider is to add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt before any #include to make sure all messages are appropriately prefixed by subsystem name

Re: [PATCH 1/4] serial: sh-sci: Replace printk() by pr_*()

2014-03-11 Thread Laurent Pinchart
Hi Geert, Thank you for the patches. I had patches similar to 3/4 and 4/4 in my tree, that's a sign you're going in the right direction (or at least the direction I consider to be right :-)). For the whole series, Acked-by: Laurent Pinchart On Tuesday 11 March 2014 11:11:17 Geert Uytterhoeve

[PATCH 1/4] serial: sh-sci: Replace printk() by pr_*()

2014-03-11 Thread Geert Uytterhoeven
From: Geert Uytterhoeven Make banner const while we're at it Signed-off-by: Geert Uytterhoeven --- drivers/tty/serial/sh-sci.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 7958115e6a51..24ec6ef6798