Re: [PATCH 1/4] spi: For controllers that need realtime always use the pump thread

2019-05-14 Thread Mark Brown
On Tue, May 14, 2019 at 07:42:38AM -0700, Doug Anderson wrote: > ...but I guess you're saying that you don't want to guarantee that the > SPI core will happen to have this thread sitting around in the future > so you'd rather add the extra complexity to cros_ec so the core can > evolve more

Re: [PATCH 1/4] spi: For controllers that need realtime always use the pump thread

2019-05-14 Thread Doug Anderson
Hi, On Tue, May 14, 2019 at 2:30 AM Mark Brown wrote: > On Mon, May 13, 2019 at 01:24:57PM -0700, Doug Anderson wrote: > > On Sun, May 12, 2019 at 10:05 AM Mark Brown wrote: > > > In my case performance is 2nd place to a transfer not getting > > interrupted once started (so we don't break the

Re: [PATCH 1/4] spi: For controllers that need realtime always use the pump thread

2019-05-14 Thread Mark Brown
On Mon, May 13, 2019 at 01:24:57PM -0700, Doug Anderson wrote: > On Sun, May 12, 2019 at 10:05 AM Mark Brown wrote: > > If performance is important you probably also want to avoid the context > > thrashing - executing in the calling context is generally a substantial > > performance boost. I

Re: [PATCH 1/4] spi: For controllers that need realtime always use the pump thread

2019-05-13 Thread Doug Anderson
Hi, On Sun, May 12, 2019 at 10:05 AM Mark Brown wrote: > On Fri, May 10, 2019 at 03:34:34PM -0700, Douglas Anderson wrote: > > If a controller specifies that it needs high priority for sending > > messages we should always schedule our transfers on the thread. If we > > don't do this we'll do

Re: [PATCH 1/4] spi: For controllers that need realtime always use the pump thread

2019-05-12 Thread Mark Brown
On Fri, May 10, 2019 at 03:34:34PM -0700, Douglas Anderson wrote: > If a controller specifies that it needs high priority for sending > messages we should always schedule our transfers on the thread. If we > don't do this we'll do the transfer in the caller's context which > might not be very

Re: [PATCH 1/4] spi: For controllers that need realtime always use the pump thread

2019-05-10 Thread Guenter Roeck
From: Douglas Anderson Date: Fri, May 10, 2019 at 3:35 PM To: Mark Brown, Benson Leung, Enric Balletbo i Serra Cc: , , Guenter Roeck, , , Douglas Anderson, , > If a controller specifies that it needs high priority for sending > messages we should always schedule our transfers on the thread. If

[PATCH 1/4] spi: For controllers that need realtime always use the pump thread

2019-05-10 Thread Douglas Anderson
If a controller specifies that it needs high priority for sending messages we should always schedule our transfers on the thread. If we don't do this we'll do the transfer in the caller's context which might not be very high priority. Signed-off-by: Douglas Anderson --- drivers/spi/spi.c | 7