Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Lorenzo Stoakes wrote: > On 31 December 2014 at 19:00, Konrad Zapalowicz > wrote: > > > > You also fix the line length here which shall be the subject of a > > separate patch as this is not C99 comments related change. > > > > Apologies - I missed this, will prepare a v2 with this sepa

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Lorenzo Stoakes
On 31 December 2014 at 19:23, Jeremiah Mahler wrote: > But this change is not related to C99 comments and you didn't > explain why this change was made in your log message. > It should probably be in a separate patch. Absolutely, I am currently fixing this and checking for any other instances whe

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Jeremiah Mahler
Lorenzo, On Wed, Dec 31, 2014 at 06:42:53PM +, Lorenzo Stoakes wrote: > This patch fixes errors raised by checkpatch.pl relating to use of C99 > comments > in r8192U_dm.c. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 841 > ++---

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Lorenzo Stoakes
On 31 December 2014 at 19:00, Konrad Zapalowicz wrote: > > You also fix the line length here which shall be the subject of a > separate patch as this is not C99 comments related change. > Apologies - I missed this, will prepare a v2 with this separated out into a different patch. Relatedly, the i

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Lorenzo Stoakes wrote: > This patch fixes errors raised by checkpatch.pl relating to use of C99 > comments > in r8192U_dm.c. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 841 > ++- > 1 file changed, 432 insertions(+

[PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Lorenzo Stoakes
This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 841 ++- 1 file changed, 432 insertions(+), 409 deletions(-) diff --git a/drivers/staging/rtl