Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

Al Viro wrote: > > I understand wanting to avoid extra arguments, but you are asking for > > trouble with that sort of calling conventions. Verifying that all call > > chains have these fields initialized is bloody unpleasant and it *is* > > going to break, especially

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

Al Viro wrote: > > I understand wanting to avoid extra arguments, but you are asking for > > trouble with that sort of calling conventions. Verifying that all call > > chains have these fields initialized is bloody unpleasant and it *is* > > going to break, especially since the rules are "you

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Sun, Dec 4, 2016 at 6:33 PM, Al Viro wrote: > On Sun, Dec 04, 2016 at 04:38:05AM +, Al Viro wrote: > >> I understand wanting to avoid extra arguments, but you are asking for trouble >> with that sort of calling conventions. Verifying that all call chains have >>

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Sun, Dec 4, 2016 at 6:33 PM, Al Viro wrote: > On Sun, Dec 04, 2016 at 04:38:05AM +, Al Viro wrote: > >> I understand wanting to avoid extra arguments, but you are asking for trouble >> with that sort of calling conventions. Verifying that all call chains have >> these fields initialized

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Sun, Dec 04, 2016 at 04:38:05AM +, Al Viro wrote: > I understand wanting to avoid extra arguments, but you are asking for trouble > with that sort of calling conventions. Verifying that all call chains have > these fields initialized is bloody unpleasant and it *is* going to break, >

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Sun, Dec 04, 2016 at 04:38:05AM +, Al Viro wrote: > I understand wanting to avoid extra arguments, but you are asking for trouble > with that sort of calling conventions. Verifying that all call chains have > these fields initialized is bloody unpleasant and it *is* going to break, >

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Sun, Dec 04, 2016 at 04:38:05AM +, Al Viro wrote: > I understand wanting to avoid extra arguments, but you are asking for trouble > with that sort of calling conventions. Verifying that all call chains have > these fields initialized is bloody unpleasant and it *is* going to break, >

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Sun, Dec 04, 2016 at 04:38:05AM +, Al Viro wrote: > I understand wanting to avoid extra arguments, but you are asking for trouble > with that sort of calling conventions. Verifying that all call chains have > these fields initialized is bloody unpleasant and it *is* going to break, >

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Wed, Nov 23, 2016 at 12:55:51AM +, David Howells wrote: > + * vfs_xgetattr - Get the enhanced basic attributes of a file > + * @path: The file of interest > + * @stat: Where to return the statistics > + * > + * Ask the filesystem for a file's attributes. The caller must have preset > + *

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Wed, Nov 23, 2016 at 12:55:51AM +, David Howells wrote: > + * vfs_xgetattr - Get the enhanced basic attributes of a file > + * @path: The file of interest > + * @stat: Where to return the statistics > + * > + * Ask the filesystem for a file's attributes. The caller must have preset > + *

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Wed, Nov 23, 2016 at 12:55:51AM +, David Howells wrote: > -int vfs_getattr_nosec(struct path *path, struct kstat *stat) > +int vfs_xgetattr_nosec(struct path *path, struct kstat *stat) const struct path *, please. Especially since we feed >f_path to it. And yes, I realize that the same

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Wed, Nov 23, 2016 at 12:55:51AM +, David Howells wrote: > -int vfs_getattr_nosec(struct path *path, struct kstat *stat) > +int vfs_xgetattr_nosec(struct path *path, struct kstat *stat) const struct path *, please. Especially since we feed >f_path to it. And yes, I realize that the same

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

Hi Andreas, On 11/23/2016 11:57 PM, Andreas Dilger wrote: > On Nov 23, 2016, at 1:37 AM, Michael Kerrisk wrote: >> [...] >>> === >>> NEW SYSTEM CALL >>> === >>> >>> The new system call is: >>> >>> int ret = statx(int dfd, >>>

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

Hi Andreas, On 11/23/2016 11:57 PM, Andreas Dilger wrote: > On Nov 23, 2016, at 1:37 AM, Michael Kerrisk wrote: >> [...] >>> === >>> NEW SYSTEM CALL >>> === >>> >>> The new system call is: >>> >>> int ret = statx(int dfd, >>> const char

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

Andreas Dilger wrote: > > + case S_IFCHR: printf(" character special file\n");ft = > > 'c'; break; > > This will overflow 80 columns. Could use just "character special"? > > > + case S_IFDIR: printf(" directory\n"); ft = > >

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

Andreas Dilger wrote: > > + case S_IFCHR: printf(" character special file\n");ft = > > 'c'; break; > > This will overflow 80 columns. Could use just "character special"? > > > + case S_IFDIR: printf(" directory\n"); ft = > > 'd'; break; > > +

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

> On Nov 22, 2016, at 5:55 PM, David Howells wrote: > > Add a system call to make extended file information available, including > file creation and some attribute flags where available through the > underlying filesystem. > > > > OVERVIEW > > > The

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

> On Nov 22, 2016, at 5:55 PM, David Howells wrote: > > Add a system call to make extended file information available, including > file creation and some attribute flags where available through the > underlying filesystem. > > > > OVERVIEW > > > The idea was initially

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Nov 23, 2016, at 1:37 AM, Michael Kerrisk wrote: > > Hi David, > > On 11/23/2016 01:55 AM, David Howells wrote: >> Add a system call to make extended file information available, including >> file creation and some attribute flags where available through the >>

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Nov 23, 2016, at 1:37 AM, Michael Kerrisk wrote: > > Hi David, > > On 11/23/2016 01:55 AM, David Howells wrote: >> Add a system call to make extended file information available, including >> file creation and some attribute flags where available through the >> underlying filesystem. >> >>

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Nov 23, 2016, at 1:37 AM, Michael Kerrisk wrote: > > Hi David, > > On 11/23/2016 01:55 AM, David Howells wrote: >> Add a system call to make extended file information available, including >> file creation and some attribute flags where available through the >>

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

On Nov 23, 2016, at 1:37 AM, Michael Kerrisk wrote: > > Hi David, > > On 11/23/2016 01:55 AM, David Howells wrote: >> Add a system call to make extended file information available, including >> file creation and some attribute flags where available through the >> underlying filesystem. >> >>

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

Hi David, On 11/23/2016 01:55 AM, David Howells wrote: > Add a system call to make extended file information available, including > file creation and some attribute flags where available through the > underlying filesystem. > > > > OVERVIEW > > > The idea was initially

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

Hi David, On 11/23/2016 01:55 AM, David Howells wrote: > Add a system call to make extended file information available, including > file creation and some attribute flags where available through the > underlying filesystem. > > > > OVERVIEW > > > The idea was initially

[PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

Add a system call to make extended file information available, including file creation and some attribute flags where available through the underlying filesystem. OVERVIEW The idea was initially proposed as a set of xattrs that could be retrieved with getxattr(), but the

[PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

Add a system call to make extended file information available, including file creation and some attribute flags where available through the underlying filesystem. OVERVIEW The idea was initially proposed as a set of xattrs that could be retrieved with getxattr(), but the