Re: [PATCH 1/4] sysfs: Support is_visible() on binary attributes

2015-10-07 Thread Olof Johansson
On Sun, Oct 04, 2015 at 07:33:34PM +0100, Greg KH wrote: > On Mon, Sep 21, 2015 at 10:38:20AM -0300, Emilio L?pez wrote: > > According to the sysfs header file: > > > > "The returned value will replace static permissions defined in > > struct attribute or struct bin_attribute." > > > >

Re: [PATCH 1/4] sysfs: Support is_visible() on binary attributes

2015-10-07 Thread Olof Johansson
On Sun, Oct 04, 2015 at 07:33:34PM +0100, Greg KH wrote: > On Mon, Sep 21, 2015 at 10:38:20AM -0300, Emilio L?pez wrote: > > According to the sysfs header file: > > > > "The returned value will replace static permissions defined in > > struct attribute or struct bin_attribute." > > > >

Re: [PATCH 1/4] sysfs: Support is_visible() on binary attributes

2015-10-04 Thread Greg KH
On Mon, Sep 21, 2015 at 10:38:20AM -0300, Emilio López wrote: > According to the sysfs header file: > > "The returned value will replace static permissions defined in > struct attribute or struct bin_attribute." > > but this isn't the case, as is_visible is only called on struct

Re: [PATCH 1/4] sysfs: Support is_visible() on binary attributes

2015-10-04 Thread Greg KH
On Mon, Sep 21, 2015 at 10:38:20AM -0300, Emilio López wrote: > According to the sysfs header file: > > "The returned value will replace static permissions defined in > struct attribute or struct bin_attribute." > > but this isn't the case, as is_visible is only called on struct

Re: [PATCH 1/4] sysfs: Support is_visible() on binary attributes

2015-09-21 Thread Emilio López
This is v3, even if the subject doesn't say so. This is what happens when you forget to use --reroll-count and try to fix it manually :) Emilio On 21/09/15 10:38, Emilio López wrote: According to the sysfs header file: "The returned value will replace static permissions defined in

[PATCH 1/4] sysfs: Support is_visible() on binary attributes

2015-09-21 Thread Emilio López
According to the sysfs header file: "The returned value will replace static permissions defined in struct attribute or struct bin_attribute." but this isn't the case, as is_visible is only called on struct attribute only. This patch introduces a new is_bin_visible() function to

[PATCH 1/4] sysfs: Support is_visible() on binary attributes

2015-09-21 Thread Emilio López
According to the sysfs header file: "The returned value will replace static permissions defined in struct attribute or struct bin_attribute." but this isn't the case, as is_visible is only called on struct attribute only. This patch introduces a new is_bin_visible() function to

Re: [PATCH 1/4] sysfs: Support is_visible() on binary attributes

2015-09-21 Thread Emilio López
This is v3, even if the subject doesn't say so. This is what happens when you forget to use --reroll-count and try to fix it manually :) Emilio On 21/09/15 10:38, Emilio López wrote: According to the sysfs header file: "The returned value will replace static permissions defined in