Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-06 Thread Namhyung Kim
Hi Steve and Jiri, 2014-01-06 PM 11:45, Steven Rostedt wrote: On Mon, 6 Jan 2014 15:38:28 +0100 Jiri Olsa wrote: I just thought that it's not so important to print message so keeps the error internally until it gets printed. But I can be wrong as usual... I think that if she manages to

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-06 Thread Steven Rostedt
On Mon, 6 Jan 2014 15:38:28 +0100 Jiri Olsa wrote: > > I just thought that it's not so important to print message so keeps the > > error internally until it gets printed. But I can be wrong as usual... > > I think that if she manages to get one of those errors > the perf would fail soon

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-06 Thread Jiri Olsa
On Mon, Jan 06, 2014 at 04:44:18PM +0900, Namhyung Kim wrote: SNIP > >> + (s)->state = TRACE_SEQ__BUFFER_POISONED;\ > > > > So unless we use trace_seq_do_printf we dont have any > > notification that this went wrong..? > > Right. > > > > > How about use some sort of

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-06 Thread Jiri Olsa
On Mon, Jan 06, 2014 at 04:44:18PM +0900, Namhyung Kim wrote: SNIP + (s)-state = TRACE_SEQ__BUFFER_POISONED;\ So unless we use trace_seq_do_printf we dont have any notification that this went wrong..? Right. How about use some sort of WARN_ONCE any time

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-06 Thread Steven Rostedt
On Mon, 6 Jan 2014 15:38:28 +0100 Jiri Olsa jo...@redhat.com wrote: I just thought that it's not so important to print message so keeps the error internally until it gets printed. But I can be wrong as usual... I think that if she manages to get one of those errors the perf would fail

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-06 Thread Namhyung Kim
Hi Steve and Jiri, 2014-01-06 PM 11:45, Steven Rostedt wrote: On Mon, 6 Jan 2014 15:38:28 +0100 Jiri Olsa jo...@redhat.com wrote: I just thought that it's not so important to print message so keeps the error internally until it gets printed. But I can be wrong as usual... I think that if

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-05 Thread Namhyung Kim
Hi Jiri, On Fri, 3 Jan 2014 14:24:25 +0100, Jiri Olsa wrote: > On Thu, Dec 19, 2013 at 06:34:23PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim >> >> The trace_seq->state is for tracking errors during the use of >> trace_seq APIs and getting rid of die() in it. >> >> Signed-off-by: Namhyung

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-05 Thread Namhyung Kim
Hi Jiri, On Fri, 3 Jan 2014 14:24:25 +0100, Jiri Olsa wrote: On Thu, Dec 19, 2013 at 06:34:23PM +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com The trace_seq-state is for tracking errors during the use of trace_seq APIs and getting rid of die() in it. Signed-off-by:

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-03 Thread Jiri Olsa
On Thu, Dec 19, 2013 at 06:34:23PM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > The trace_seq->state is for tracking errors during the use of > trace_seq APIs and getting rid of die() in it. > > Signed-off-by: Namhyung Kim > --- > tools/lib/traceevent/event-parse.h | 7 +++ >

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-03 Thread Jiri Olsa
On Thu, Dec 19, 2013 at 06:34:23PM +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com The trace_seq-state is for tracking errors during the use of trace_seq APIs and getting rid of die() in it. Signed-off-by: Namhyung Kim namhy...@kernel.org ---

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-02 Thread Namhyung Kim
Ping! On Thu, 19 Dec 2013 18:34:23 +0900, Namhyung Kim wrote: > From: Namhyung Kim > > The trace_seq->state is for tracking errors during the use of > trace_seq APIs and getting rid of die() in it. > > Signed-off-by: Namhyung Kim > --- > tools/lib/traceevent/event-parse.h | 7 +++ >

Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2014-01-02 Thread Namhyung Kim
Ping! On Thu, 19 Dec 2013 18:34:23 +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com The trace_seq-state is for tracking errors during the use of trace_seq APIs and getting rid of die() in it. Signed-off-by: Namhyung Kim namhy...@kernel.org ---

[PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2013-12-19 Thread Namhyung Kim
From: Namhyung Kim The trace_seq->state is for tracking errors during the use of trace_seq APIs and getting rid of die() in it. Signed-off-by: Namhyung Kim --- tools/lib/traceevent/event-parse.h | 7 +++ tools/lib/traceevent/trace-seq.c | 41 ++ 2

[PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq

2013-12-19 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com The trace_seq-state is for tracking errors during the use of trace_seq APIs and getting rid of die() in it. Signed-off-by: Namhyung Kim namhy...@kernel.org --- tools/lib/traceevent/event-parse.h | 7 +++ tools/lib/traceevent/trace-seq.c | 41