On Wed, Dec 20, 2017 at 12:35:35PM +0100, Javier Martinez Canillas wrote:
> The driver maps the I/O memory address to control the LPC bus CLKRUN_EN,
> but on the error path the memory is accessed by the .clk_enable handler
> after this was already unmapped. So only unmap the I/O memory region if
>
On Wed, Dec 20, 2017 at 12:35:35PM +0100, Javier Martinez Canillas wrote:
> The driver maps the I/O memory address to control the LPC bus CLKRUN_EN,
> but on the error path the memory is accessed by the .clk_enable handler
> after this was already unmapped. So only unmap the I/O memory region if
>
eter Huewe
>; Greg Kroah-Hartman
>; linux-integr...@vger.kernel.org
>Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O
>memory region
>
>On 12/21/2017 04:39 PM, Shaikh, Azhar wrote:
>> HI Javier,
>>
>>
>>> -Original Messa
2017 4:49 AM
>> To: Shaikh, Azhar ; Jason Gunthorpe
>>
>> Cc: linux-kernel@vger.kernel.org; James Ettle ; Hans de
>> Goede ; Arnd Bergmann ; Jarkko
>> Sakkinen ; Peter Huewe
>> ; Greg Kroah-Hartman
>> ; linux-integr...@vger.kernel.org
>> Subject: Re
ger.kernel.org; James Ettle ; Hans de
>Goede ; Arnd Bergmann ; Jarkko
>Sakkinen ; Peter Huewe
>; Greg Kroah-Hartman
>; linux-integr...@vger.kernel.org
>Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O
>memory region
>
>Hello Azhar,
&
.org; James Ettle ; Hans de
>> Goede ; Shaikh, Azhar ;
>> Arnd Bergmann ; Jarkko Sakkinen
>> ; Peter Huewe ;
>> Greg Kroah-Hartman ; linux-
>> integr...@vger.kernel.org
>> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O
>> memory region
eter Huewe ;
>Greg Kroah-Hartman ; linux-
>integr...@vger.kernel.org
>Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O
>memory region
>
>On Wed, Dec 20, 2017 at 07:21:31PM +0100, Javier Martinez Canillas wrote:
>
>> > The below draft fixes everyt
On Wed, Dec 20, 2017 at 07:21:31PM +0100, Javier Martinez Canillas wrote:
> > The below draft fixes everything except #1. That needs a more thoughtful
> > idea..
> >
>
> I'll just drop this patch from the series and you can fix all the issues in
> the error / driver removal paths. It's not a depe
On 12/20/2017 07:08 PM, Jason Gunthorpe wrote:
> On Wed, Dec 20, 2017 at 12:35:35PM +0100, Javier Martinez Canillas wrote:
>> The driver maps the I/O memory address to control the LPC bus CLKRUN_EN,
>> but on the error path the memory is accessed by the .clk_enable handler
>> after this was already
On Wed, Dec 20, 2017 at 12:35:35PM +0100, Javier Martinez Canillas wrote:
> The driver maps the I/O memory address to control the LPC bus CLKRUN_EN,
> but on the error path the memory is accessed by the .clk_enable handler
> after this was already unmapped. So only unmap the I/O memory region if
>
o Sakkinen ; Peter Huewe
>; Jason Gunthorpe ; Greg Kroah-
>Hartman ; linux-integr...@vger.kernel.org
>Subject: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O
>memory region
>
>The driver maps the I/O memory address to control the LPC bus CLKRUN_EN,
>but on
The driver maps the I/O memory address to control the LPC bus CLKRUN_EN,
but on the error path the memory is accessed by the .clk_enable handler
after this was already unmapped. So only unmap the I/O memory region if
it will not be used anymore.
Also, the correct thing to do is to cleanup the reso
12 matches
Mail list logo
