Re: [PATCH 1/4] vtime: Remove the underscore prefix invasion

2012-11-14 Thread Steven Rostedt
On Wed, 2012-11-14 at 17:48 +0100, Frederic Weisbecker wrote: > 2012/11/14 Steven Rostedt : > > On Wed, 2012-11-14 at 17:26 +0100, Frederic Weisbecker wrote: > >> Prepending irq-unsafe vtime APIs with underscores was actually > >> a bad idea as the result is a big mess in the API namespace that >

Re: [PATCH 1/4] vtime: Remove the underscore prefix invasion

2012-11-14 Thread Frederic Weisbecker
2012/11/14 Steven Rostedt : > On Wed, 2012-11-14 at 17:26 +0100, Frederic Weisbecker wrote: >> Prepending irq-unsafe vtime APIs with underscores was actually >> a bad idea as the result is a big mess in the API namespace that >> is even waiting to be further extended. Also these helpers >> are

Re: [PATCH 1/4] vtime: Remove the underscore prefix invasion

2012-11-14 Thread Steven Rostedt
On Wed, 2012-11-14 at 17:26 +0100, Frederic Weisbecker wrote: > Prepending irq-unsafe vtime APIs with underscores was actually > a bad idea as the result is a big mess in the API namespace that > is even waiting to be further extended. Also these helpers > are always called from irq safe callers

[PATCH 1/4] vtime: Remove the underscore prefix invasion

2012-11-14 Thread Frederic Weisbecker
Prepending irq-unsafe vtime APIs with underscores was actually a bad idea as the result is a big mess in the API namespace that is even waiting to be further extended. Also these helpers are always called from irq safe callers except kvm. Just provide a vtime_account_system_irqsafe() for this

[PATCH 1/4] vtime: Remove the underscore prefix invasion

2012-11-14 Thread Frederic Weisbecker
Prepending irq-unsafe vtime APIs with underscores was actually a bad idea as the result is a big mess in the API namespace that is even waiting to be further extended. Also these helpers are always called from irq safe callers except kvm. Just provide a vtime_account_system_irqsafe() for this

Re: [PATCH 1/4] vtime: Remove the underscore prefix invasion

2012-11-14 Thread Steven Rostedt
On Wed, 2012-11-14 at 17:26 +0100, Frederic Weisbecker wrote: Prepending irq-unsafe vtime APIs with underscores was actually a bad idea as the result is a big mess in the API namespace that is even waiting to be further extended. Also these helpers are always called from irq safe callers

Re: [PATCH 1/4] vtime: Remove the underscore prefix invasion

2012-11-14 Thread Frederic Weisbecker
2012/11/14 Steven Rostedt rost...@goodmis.org: On Wed, 2012-11-14 at 17:26 +0100, Frederic Weisbecker wrote: Prepending irq-unsafe vtime APIs with underscores was actually a bad idea as the result is a big mess in the API namespace that is even waiting to be further extended. Also these

Re: [PATCH 1/4] vtime: Remove the underscore prefix invasion

2012-11-14 Thread Steven Rostedt
On Wed, 2012-11-14 at 17:48 +0100, Frederic Weisbecker wrote: 2012/11/14 Steven Rostedt rost...@goodmis.org: On Wed, 2012-11-14 at 17:26 +0100, Frederic Weisbecker wrote: Prepending irq-unsafe vtime APIs with underscores was actually a bad idea as the result is a big mess in the API