Re: [PATCH 1/4] watchdog device drivers:pc87413_wdt:Rewriting of pc87413_wdt driver to utilize common watchdog interface

2019-07-29 Thread Mark Balantzyan
Yes, each time I go through an edit I discover something I missed, apologies. Will be working on it for a bit, currently getting compile time errors. Just letting you know and it’s good we’re checking :-) Thank you, Mark

Re: [PATCH 1/4] watchdog device drivers:pc87413_wdt:Rewriting of pc87413_wdt driver to utilize common watchdog interface

2019-07-29 Thread Guenter Roeck
On 7/29/19 7:15 PM, Mark Balantzyan wrote: There is a potential for the variable swc_base_addr in the call chain of the driver initialization function (init) to be used before initialization. This brought up the need for, by rewriting the driver to use the common watchdog interface, ensuring to h

Re: [PATCH 1/4] watchdog device drivers:pc87413_wdt:Rewriting of pc87413_wdt driver to utilize common watchdog interface

2019-07-29 Thread Guenter Roeck
On 7/29/19 7:15 PM, Mark Balantzyan wrote: There is a potential for the variable swc_base_addr in the call chain of the driver initialization function (init) to be used before initialization. This brought up the need for, by rewriting the driver to use the common watchdog interface, ensuring to h

[PATCH 1/4] watchdog device drivers:pc87413_wdt:Rewriting of pc87413_wdt driver to utilize common watchdog interface

2019-07-29 Thread Mark Balantzyan
There is a potential for the variable swc_base_addr in the call chain of the driver initialization function (init) to be used before initialization. This brought up the need for, by rewriting the driver to use the common watchdog interface, ensuring to have all resources in place. This patch addres