Re: [PATCH 1/4] x86: clean up asm-x86/page*.h

2007-12-14 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > >> Unify common definitions in page*.h. To simplify other code, I added >> typedefs for the value of pte/pmd/pud/pgd values, so they can be used >> symbolically elsewhere without needing to have lots of 32/64/PAE >> te

Re: [PATCH 1/4] x86: clean up asm-x86/page*.h

2007-12-14 Thread Glauber de Oliveira Costa
On Dec 14, 2007 6:53 AM, Jan Beulich <[EMAIL PROTECTED]> wrote: > >>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 14.12.07 09:44 >>> > > >Jan Beulich wrote: > >>> --- a/arch/x86/mm/fault_64.c > >>> +++ b/arch/x86/mm/fault_64.c > >>> @@ -158,22 +158,22 @@ void dump_pagetable(unsigned long addres > >>>

Re: [PATCH 1/4] x86: clean up asm-x86/page*.h

2007-12-14 Thread Harvey Harrison
On Fri, 2007-12-14 at 00:12 -0800, Jeremy Fitzhardinge wrote: > Unify common definitions in page*.h. To simplify other code, I added > typedefs for the value of pte/pmd/pud/pgd values, so they can be used > symbolically elsewhere without needing to have lots of 32/64/PAE > tests. > > Also, add PA

Re: [PATCH 1/4] x86: clean up asm-x86/page*.h

2007-12-14 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Unify common definitions in page*.h. To simplify other code, I added > typedefs for the value of pte/pmd/pud/pgd values, so they can be used > symbolically elsewhere without needing to have lots of 32/64/PAE > tests. > > Also, add PAGETABLE_

Re: [PATCH 1/4] x86: clean up asm-x86/page*.h

2007-12-14 Thread Jan Beulich
>>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 14.12.07 09:44 >>> >Jan Beulich wrote: >>> --- a/arch/x86/mm/fault_64.c >>> +++ b/arch/x86/mm/fault_64.c >>> @@ -158,22 +158,22 @@ void dump_pagetable(unsigned long addres >>> pgd = __va((unsigned long)pgd & PHYSICAL_PAGE_MASK); >>> pgd += pgd_in

Re: [PATCH 1/4] x86: clean up asm-x86/page*.h

2007-12-14 Thread Jeremy Fitzhardinge
Jan Beulich wrote: >> --- a/arch/x86/mm/fault_64.c >> +++ b/arch/x86/mm/fault_64.c >> @@ -158,22 +158,22 @@ void dump_pagetable(unsigned long addres >> pgd = __va((unsigned long)pgd & PHYSICAL_PAGE_MASK); >> pgd += pgd_index(address); >> if (bad_address(pgd)) goto bad; >> -print

Re: [PATCH 1/4] x86: clean up asm-x86/page*.h

2007-12-14 Thread Jan Beulich
>--- a/arch/x86/mm/fault_64.c >+++ b/arch/x86/mm/fault_64.c >@@ -158,22 +158,22 @@ void dump_pagetable(unsigned long addres > pgd = __va((unsigned long)pgd & PHYSICAL_PAGE_MASK); > pgd += pgd_index(address); > if (bad_address(pgd)) goto bad; >- printk("PGD %lx ", pgd_val(*pg

[PATCH 1/4] x86: clean up asm-x86/page*.h

2007-12-14 Thread Jeremy Fitzhardinge
Unify common definitions in page*.h. To simplify other code, I added typedefs for the value of pte/pmd/pud/pgd values, so they can be used symbolically elsewhere without needing to have lots of 32/64/PAE tests. Also, add PAGETABLE_LEVELS define so that other definitions can test for it directly r