Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-11 Thread Seth Jennings
On 07/11/2012 05:42 PM, Nitin Gupta wrote: > On Wed, Jul 11, 2012 at 1:32 PM, Seth Jennings > wrote: >> On 07/11/2012 01:26 PM, Nitin Gupta wrote: >>> Now obj-1 lies completely within page-2, so can be kmap'ed as usual. On >>> zs_unmap_object() we would just do the reverse and restore objects as

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-11 Thread Nitin Gupta
On Wed, Jul 11, 2012 at 1:32 PM, Seth Jennings wrote: > On 07/11/2012 01:26 PM, Nitin Gupta wrote: >> On 07/02/2012 02:15 PM, Seth Jennings wrote: >>> This patch replaces the page table assisted object mapping >>> method, which has x86 dependencies, with a arch-independent >>> method that does a

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-11 Thread Seth Jennings
On 07/11/2012 01:26 PM, Nitin Gupta wrote: > On 07/02/2012 02:15 PM, Seth Jennings wrote: >> This patch replaces the page table assisted object mapping >> method, which has x86 dependencies, with a arch-independent >> method that does a simple copy into a temporary per-cpu >> buffer. >> >> While a

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-11 Thread Nitin Gupta
On 07/02/2012 02:15 PM, Seth Jennings wrote: > This patch replaces the page table assisted object mapping > method, which has x86 dependencies, with a arch-independent > method that does a simple copy into a temporary per-cpu > buffer. > > While a copy seems like it would be worse than mapping

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-11 Thread Minchan Kim
On 07/11/2012 12:29 AM, Seth Jennings wrote: > On 07/09/2012 09:21 PM, Minchan Kim wrote: >> On 07/03/2012 06:15 AM, Seth Jennings wrote: > >>> +static void zs_copy_map_object(char *buf, struct page *firstpage, >>> + int off, int size) >> >> firstpage is rather

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-11 Thread Minchan Kim
On 07/11/2012 12:29 AM, Seth Jennings wrote: On 07/09/2012 09:21 PM, Minchan Kim wrote: On 07/03/2012 06:15 AM, Seth Jennings wrote: snip +static void zs_copy_map_object(char *buf, struct page *firstpage, + int off, int size) firstpage is rather misleading. As you

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-11 Thread Nitin Gupta
On 07/02/2012 02:15 PM, Seth Jennings wrote: This patch replaces the page table assisted object mapping method, which has x86 dependencies, with a arch-independent method that does a simple copy into a temporary per-cpu buffer. While a copy seems like it would be worse than mapping the

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-11 Thread Seth Jennings
On 07/11/2012 01:26 PM, Nitin Gupta wrote: On 07/02/2012 02:15 PM, Seth Jennings wrote: This patch replaces the page table assisted object mapping method, which has x86 dependencies, with a arch-independent method that does a simple copy into a temporary per-cpu buffer. While a copy seems

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-11 Thread Nitin Gupta
On Wed, Jul 11, 2012 at 1:32 PM, Seth Jennings sjenn...@linux.vnet.ibm.com wrote: On 07/11/2012 01:26 PM, Nitin Gupta wrote: On 07/02/2012 02:15 PM, Seth Jennings wrote: This patch replaces the page table assisted object mapping method, which has x86 dependencies, with a arch-independent

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-11 Thread Seth Jennings
On 07/11/2012 05:42 PM, Nitin Gupta wrote: On Wed, Jul 11, 2012 at 1:32 PM, Seth Jennings sjenn...@linux.vnet.ibm.com wrote: On 07/11/2012 01:26 PM, Nitin Gupta wrote: snip Now obj-1 lies completely within page-2, so can be kmap'ed as usual. On zs_unmap_object() we would just do the reverse

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-10 Thread Seth Jennings
On 07/09/2012 09:21 PM, Minchan Kim wrote: > On 07/03/2012 06:15 AM, Seth Jennings wrote: >> +static void zs_copy_map_object(char *buf, struct page *firstpage, >> +int off, int size) > > firstpage is rather misleading. > As you know, we use firstpage term for real

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-10 Thread Seth Jennings
On 07/09/2012 09:21 PM, Minchan Kim wrote: On 07/03/2012 06:15 AM, Seth Jennings wrote: snip +static void zs_copy_map_object(char *buf, struct page *firstpage, +int off, int size) firstpage is rather misleading. As you know, we use firstpage term for real

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-09 Thread Minchan Kim
On 07/03/2012 06:15 AM, Seth Jennings wrote: > This patch replaces the page table assisted object mapping > method, which has x86 dependencies, with a arch-independent > method that does a simple copy into a temporary per-cpu > buffer. > > While a copy seems like it would be worse than mapping

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-09 Thread Minchan Kim
On 07/03/2012 06:15 AM, Seth Jennings wrote: This patch replaces the page table assisted object mapping method, which has x86 dependencies, with a arch-independent method that does a simple copy into a temporary per-cpu buffer. While a copy seems like it would be worse than mapping the