Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On October 27, 2015 4:40:42 PM GMT+05:30, Dan Carpenter wrote: >On Tue, Oct 27, 2015 at 11:45:18AM +0200, Leon Romanovsky wrote: >> On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter >> wrote: >> > On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: >> >> On Sun, Oct 25, 2015 at

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Tue, Oct 27, 2015 at 11:45:18AM +0200, Leon Romanovsky wrote: > On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter > wrote: > > On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: > >> On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani > >> wrote: > >> Please follow standard

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter wrote: > On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: >> On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani >> wrote: >> Please follow standard naming convention for the patches. >> It should be [PATCH v2 1/4] and not

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: > On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani > wrote: > Please follow standard naming convention for the patches. > It should be [PATCH v2 1/4] and not [PATCH 1/4 v2]. Does this matter? It's in a thread so it sorts

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: > On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani > wrote: > Please follow standard naming convention for the patches. > It should be [PATCH v2 1/4] and not [PATCH 1/4 v2]. Does this matter? It's in a

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter wrote: > On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: >> On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani >> wrote: >> Please follow standard naming convention for the

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Tue, Oct 27, 2015 at 11:45:18AM +0200, Leon Romanovsky wrote: > On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter > wrote: > > On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: > >> On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani > >>

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On October 27, 2015 4:40:42 PM GMT+05:30, Dan Carpenter wrote: >On Tue, Oct 27, 2015 at 11:45:18AM +0200, Leon Romanovsky wrote: >> On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter >> wrote: >> > On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani wrote: Please follow standard naming convention for the patches. It should be [PATCH v2 1/4] and not [PATCH 1/4 v2]. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. The simplified semantic patch used is :- @timer@ expression e1,e2,e3,fn_ptr; @@ -init_timer(); +setup_timer(, fn_ptr, e2); ... when != fn_ptr = e3 -e1.function = fn_ptr; -e1.data = e2;

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani wrote: Please follow standard naming convention for the patches. It should be [PATCH v2 1/4] and not [PATCH 1/4 v2]. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. The simplified semantic patch used is :- @timer@ expression e1,e2,e3,fn_ptr; @@ -init_timer(); +setup_timer(, fn_ptr, e2); ... when != fn_ptr = e3 -e1.function = fn_ptr; -e1.data = e2;