Re: [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-19 Thread Paolo Bonzini
Il 19/08/2014 04:17, Wanpeng Li ha scritto: >>> >> -if (level == 1 || (level == 2 && (spte & (1ULL << 7 >>> >> { >>> >> +if (level == 1 || ((level == 3 || level == 2) >>> >> +&& (spte & (1ULL << 7 { >> > >> >This condition

Re: [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-19 Thread Paolo Bonzini
Il 19/08/2014 04:17, Wanpeng Li ha scritto: -if (level == 1 || (level == 2 (spte (1ULL 7 { +if (level == 1 || ((level == 3 || level == 2) + (spte (1ULL 7 { This condition can be simplified by checking the

Re: [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-18 Thread Wanpeng Li
Hi Paolo, On Mon, Aug 18, 2014 at 12:18:59PM +0200, Paolo Bonzini wrote: >Il 18/08/2014 11:50, Wanpeng Li ha scritto: >> EPT misconfig handler in kvm will check which reason lead to EPT >> misconfiguration after vmexit. One of the reasons is that an EPT >> paging-structure entry is configured

Re: [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-18 Thread Xiao Guangrong
On 08/18/2014 05:50 PM, Wanpeng Li wrote: > EPT misconfig handler in kvm will check which reason lead to EPT > misconfiguration after vmexit. One of the reasons is that an EPT > paging-structure entry is configured with settings reserved for > future functionality. However, the handler can't

Re: [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-18 Thread Paolo Bonzini
Il 18/08/2014 12:52, Xiao Guangrong ha scritto: >> > EPT misconfig handler in kvm will check which reason lead to EPT >> > misconfiguration after vmexit. One of the reasons is that an EPT >> > paging-structure entry is configured with settings reserved for >> > future functionality. However,

Re: [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-18 Thread Paolo Bonzini
Il 18/08/2014 11:50, Wanpeng Li ha scritto: > EPT misconfig handler in kvm will check which reason lead to EPT > misconfiguration after vmexit. One of the reasons is that an EPT > paging-structure entry is configured with settings reserved for > future functionality. However, the handler can't

[PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-18 Thread Wanpeng Li
EPT misconfig handler in kvm will check which reason lead to EPT misconfiguration after vmexit. One of the reasons is that an EPT paging-structure entry is configured with settings reserved for future functionality. However, the handler can't identify if paging-structure entry of reserved bits

Re: [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-18 Thread Paolo Bonzini
Il 18/08/2014 11:50, Wanpeng Li ha scritto: EPT misconfig handler in kvm will check which reason lead to EPT misconfiguration after vmexit. One of the reasons is that an EPT paging-structure entry is configured with settings reserved for future functionality. However, the handler can't

[PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-18 Thread Wanpeng Li
EPT misconfig handler in kvm will check which reason lead to EPT misconfiguration after vmexit. One of the reasons is that an EPT paging-structure entry is configured with settings reserved for future functionality. However, the handler can't identify if paging-structure entry of reserved bits

Re: [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-18 Thread Xiao Guangrong
On 08/18/2014 05:50 PM, Wanpeng Li wrote: EPT misconfig handler in kvm will check which reason lead to EPT misconfiguration after vmexit. One of the reasons is that an EPT paging-structure entry is configured with settings reserved for future functionality. However, the handler can't

Re: [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-18 Thread Paolo Bonzini
Il 18/08/2014 12:52, Xiao Guangrong ha scritto: EPT misconfig handler in kvm will check which reason lead to EPT misconfiguration after vmexit. One of the reasons is that an EPT paging-structure entry is configured with settings reserved for future functionality. However, the handler

Re: [PATCH 1/5] KVM: vmx: fix ept reserved bits for 1-GByte page

2014-08-18 Thread Wanpeng Li
Hi Paolo, On Mon, Aug 18, 2014 at 12:18:59PM +0200, Paolo Bonzini wrote: Il 18/08/2014 11:50, Wanpeng Li ha scritto: EPT misconfig handler in kvm will check which reason lead to EPT misconfiguration after vmexit. One of the reasons is that an EPT paging-structure entry is configured with