Re: [PATCH 1/5] USB: typec: tcpm: Prevent log overflow by removing old entries

2020-12-10 Thread Guenter Roeck
On Thu, Dec 10, 2020 at 11:10:27AM -0800, Badhri Jagan Sridharan wrote: > Hi Guenter, > > While I agree with what you are saying, since the logbuffer does not > have the intelligence to drop older entries where no issues were seen, > logbuffer gets full pretty quickly with good instances and there

Re: [PATCH 1/5] USB: typec: tcpm: Prevent log overflow by removing old entries

2020-12-10 Thread Badhri Jagan Sridharan
Hi Guenter, While I agree with what you are saying, since the logbuffer does not have the intelligence to drop older entries where no issues were seen, logbuffer gets full pretty quickly with good instances and there is no space left to log the bad instance. Should wrapping this in a config option

Re: [PATCH 1/5] USB: typec: tcpm: Prevent log overflow by removing old entries

2020-12-10 Thread Guenter Roeck
On Thu, Dec 10, 2020 at 05:05:17PM +0100, Greg Kroah-Hartman wrote: > From: Badhri Jagan Sridharan > > TCPM logs overflow once the logbuffer is full. Clear old entries and > allow logging the newer ones as the newer would be more relevant to the > issue being debugged. > > Also, do not reset the

[PATCH 1/5] USB: typec: tcpm: Prevent log overflow by removing old entries

2020-12-10 Thread Greg Kroah-Hartman
From: Badhri Jagan Sridharan TCPM logs overflow once the logbuffer is full. Clear old entries and allow logging the newer ones as the newer would be more relevant to the issue being debugged. Also, do not reset the logbuffer tail as end users might take back to back bugreports which would result