Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP

2012-11-15 Thread Jeff Garzik
On 10/16/2012 10:59 AM, Yuanhan Liu wrote: This will fix warnings like following when CONFIG_PM_SLEEP is not set: warning: 'xxx_suspend' defined but not used [-Wunused-function] warning: 'xxx_resume' defined but not used [-Wunused-function] Because SET_SYSTEM_SLEEP_PM_

Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP

2012-10-16 Thread viresh kumar
On Tue, Oct 16, 2012 at 8:29 PM, Yuanhan Liu wrote: > This will fix warnings like following when CONFIG_PM_SLEEP is not set: > > warning: 'xxx_suspend' defined but not used [-Wunused-function] > warning: 'xxx_resume' defined but not used [-Wunused-function] > > Because > SE

Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP

2012-10-16 Thread Fengguang Wu
// Add CC to PM list On Tue, Oct 16, 2012 at 10:59:01PM +0800, Yuanhan Liu wrote: > This will fix warnings like following when CONFIG_PM_SLEEP is not set: > > warning: 'xxx_suspend' defined but not used [-Wunused-function] > warning: 'xxx_resume' defined but not used [-Wunused-fun

[PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP

2012-10-16 Thread Yuanhan Liu
This will fix warnings like following when CONFIG_PM_SLEEP is not set: warning: 'xxx_suspend' defined but not used [-Wunused-function] warning: 'xxx_resume' defined but not used [-Wunused-function] Because SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) Only references the