Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Alexandre Belloni
On 21/03/2014 at 17:03:52 +0100, Sebastian Hesselbarth wrote : > On 03/21/2014 04:45 PM, Alexandre Belloni wrote: > >[all commentis I agree on are snipped] > > :) > > >On 21/03/2014 at 13:49:32 +0100, Sebastian Hesselbarth wrote : > >>On 03/21/2014 12:43 PM, Alexandre Belloni wrote: > >>obj-y +=

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Sebastian Hesselbarth
On 03/21/2014 04:56 PM, Alexandre Belloni wrote: On 21/03/2014 at 13:49:32 +0100, Sebastian Hesselbarth wrote : On 03/21/2014 12:43 PM, Alexandre Belloni wrote: diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index a367a9831717..4a2602737c27 100644 --- a/drivers/clk/Makefile +++

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Alexandre Belloni
On 21/03/2014 at 16:45:39 +0100, Alexandre Belloni wrote : > > >+ .fbdiv_shift = 6, > > >+ .rfdiv_shift = 1, > > >+ .divsel_shift = 7, > > > > Have .foo_mask and .foo_shift together? > > > > This will make the struct larger but I don't really have an opinion. > Forget that one, I'll take a

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Sebastian Hesselbarth
On 03/21/2014 04:45 PM, Alexandre Belloni wrote: [all commentis I agree on are snipped] :) On 21/03/2014 at 13:49:32 +0100, Sebastian Hesselbarth wrote : On 03/21/2014 12:43 PM, Alexandre Belloni wrote: obj-y += pll.o obj-$(CONFIG_MACH_BERLIN_BG2) += pll-berlin2.o

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Alexandre Belloni
On 21/03/2014 at 13:49:32 +0100, Sebastian Hesselbarth wrote : > On 03/21/2014 12:43 PM, Alexandre Belloni wrote: > >diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > >index a367a9831717..4a2602737c27 100644 > >--- a/drivers/clk/Makefile > >+++ b/drivers/clk/Makefile > >@@ -29,6 +29,7 @@

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Alexandre Belloni
[all commentis I agree on are snipped] On 21/03/2014 at 13:49:32 +0100, Sebastian Hesselbarth wrote : > On 03/21/2014 12:43 PM, Alexandre Belloni wrote: > obj-y += pll.o > obj-$(CONFIG_MACH_BERLIN_BG2) += pll-berlin2.o > obj-$(CONFIG_MACH_BERLIN_BG2CD) += pll-berlin2.o >

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Sebastian Hesselbarth
On 03/21/2014 12:43 PM, Alexandre Belloni wrote: This drivers allows to provide DT clocks for the cpu and system PLLs found on Marvell Berlin SoCs. Signed-off-by: Alexandre Belloni --- drivers/clk/Makefile | 1 + drivers/clk/berlin/Makefile | 1 +

[PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Alexandre Belloni
This drivers allows to provide DT clocks for the cpu and system PLLs found on Marvell Berlin SoCs. Signed-off-by: Alexandre Belloni --- drivers/clk/Makefile | 1 + drivers/clk/berlin/Makefile | 1 + drivers/clk/berlin/clk.h | 35 +

[PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Alexandre Belloni
This drivers allows to provide DT clocks for the cpu and system PLLs found on Marvell Berlin SoCs. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- drivers/clk/Makefile | 1 + drivers/clk/berlin/Makefile | 1 + drivers/clk/berlin/clk.h |

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Sebastian Hesselbarth
On 03/21/2014 12:43 PM, Alexandre Belloni wrote: This drivers allows to provide DT clocks for the cpu and system PLLs found on Marvell Berlin SoCs. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- drivers/clk/Makefile | 1 + drivers/clk/berlin/Makefile

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Alexandre Belloni
[all commentis I agree on are snipped] On 21/03/2014 at 13:49:32 +0100, Sebastian Hesselbarth wrote : On 03/21/2014 12:43 PM, Alexandre Belloni wrote: obj-y += pll.o obj-$(CONFIG_MACH_BERLIN_BG2) += pll-berlin2.o obj-$(CONFIG_MACH_BERLIN_BG2CD) += pll-berlin2.o

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Alexandre Belloni
On 21/03/2014 at 13:49:32 +0100, Sebastian Hesselbarth wrote : On 03/21/2014 12:43 PM, Alexandre Belloni wrote: diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index a367a9831717..4a2602737c27 100644 --- a/drivers/clk/Makefile +++ b/drivers/clk/Makefile @@ -29,6 +29,7 @@

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Sebastian Hesselbarth
On 03/21/2014 04:45 PM, Alexandre Belloni wrote: [all commentis I agree on are snipped] :) On 21/03/2014 at 13:49:32 +0100, Sebastian Hesselbarth wrote : On 03/21/2014 12:43 PM, Alexandre Belloni wrote: obj-y += pll.o obj-$(CONFIG_MACH_BERLIN_BG2) += pll-berlin2.o

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Alexandre Belloni
On 21/03/2014 at 16:45:39 +0100, Alexandre Belloni wrote : + .fbdiv_shift = 6, + .rfdiv_shift = 1, + .divsel_shift = 7, Have .foo_mask and .foo_shift together? This will make the struct larger but I don't really have an opinion. Forget that one, I'll take a break... --

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Sebastian Hesselbarth
On 03/21/2014 04:56 PM, Alexandre Belloni wrote: On 21/03/2014 at 13:49:32 +0100, Sebastian Hesselbarth wrote : On 03/21/2014 12:43 PM, Alexandre Belloni wrote: diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index a367a9831717..4a2602737c27 100644 --- a/drivers/clk/Makefile +++

Re: [PATCH 1/5] clk: berlin: add support for berlin plls

2014-03-21 Thread Alexandre Belloni
On 21/03/2014 at 17:03:52 +0100, Sebastian Hesselbarth wrote : On 03/21/2014 04:45 PM, Alexandre Belloni wrote: [all commentis I agree on are snipped] :) On 21/03/2014 at 13:49:32 +0100, Sebastian Hesselbarth wrote : On 03/21/2014 12:43 PM, Alexandre Belloni wrote: obj-y += pll.o