Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support

2019-03-13 Thread Marc Zyngier
Hi Thierry, On 13/03/2019 16:34, Thierry Reding wrote: > On Wed, Mar 13, 2019 at 02:20:41PM +, Marc Zyngier wrote: [...] >> Sure, but look at the result: >> >> - you remove your gic-pm module >> - the MMIO mapping disappears >> - the GIC data structures *are still live* >> - a driver does a

Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support

2019-03-13 Thread Thierry Reding
On Wed, Mar 13, 2019 at 02:20:41PM +, Marc Zyngier wrote: > On 13/03/2019 13:50, Sameer Pujar wrote: > > > > On 3/13/2019 4:52 PM, Marc Zyngier wrote: > >> First things first: > >> > >> - Where is the cover letter? > >> - This series should be flagged as v2, as it not the same as the one you >

Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support

2019-03-13 Thread Marc Zyngier
On 13/03/2019 13:50, Sameer Pujar wrote: > > On 3/13/2019 4:52 PM, Marc Zyngier wrote: >> First things first: >> >> - Where is the cover letter? >> - This series should be flagged as v2, as it not the same as the one you >> sent last week. > I had the dilemma whether to name this series as v2 or n

Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support

2019-03-13 Thread Sameer Pujar
On 3/13/2019 4:52 PM, Marc Zyngier wrote: First things first: - Where is the cover letter? - This series should be flagged as v2, as it not the same as the one you sent last week. I had the dilemma whether to name this series as v2 or not, thought the commits in the series are different and

Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support

2019-03-13 Thread Marc Zyngier
First things first: - Where is the cover letter? - This series should be flagged as v2, as it not the same as the one you sent last week. On 13/03/2019 11:02, Sameer Pujar wrote: > This is a preparatory patch for using irq-gic-pm driver as module and thus > implement remove() call for the driver.

[PATCH 1/5] irqchip/gic-pm: add driver remove support

2019-03-13 Thread Sameer Pujar
This is a preparatory patch for using irq-gic-pm driver as module and thus implement remove() call for the driver. Details of remove() are as below, * pm_runtime_force_suspend() is added to balance runtime PM, otherwise following is seen: "agic-controller: Unbalanced pm_runtime_enable!" * Fun