Re: [PATCH 1/5] kunit: tool: fix unit test cleanup handling

2020-11-30 Thread David Gow
On Tue, Dec 1, 2020 at 7:32 AM Daniel Latypov wrote: > > * Stop leaking file objects. > * Use self.addCleanup() to ensure we call cleanup functions even if > setUp() fails. > * use mock.patch.stopall instead of more error-prone manual approach > > Signed-off-by: Daniel Latypov > --- I won't pret

[PATCH 1/5] kunit: tool: fix unit test cleanup handling

2020-11-30 Thread Daniel Latypov
* Stop leaking file objects. * Use self.addCleanup() to ensure we call cleanup functions even if setUp() fails. * use mock.patch.stopall instead of more error-prone manual approach Signed-off-by: Daniel Latypov --- tools/testing/kunit/kunit_tool_test.py | 14 ++ 1 file changed, 6 ins