Re: [PATCH 1/5] mfd: tc3589x: add device tree bindings

2013-10-18 Thread Linus Walleij
On Wed, Oct 16, 2013 at 11:08 AM, Lee Jones wrote: > 1. MFD patches have the following syntax: > mfd: [-sub]: /* Note the uppercase 'D' */ Sure fixed this. > 2. The binding document is normally attached to the patch which > applies the bindings, unless we've stopped doing that now. This is

Re: [PATCH 1/5] mfd: tc3589x: add device tree bindings

2013-10-16 Thread Lee Jones
I'll let the DT guys do the deep review. Just a couple of small points from me though. 1. MFD patches have the following syntax: mfd: [-sub]: /* Note the uppercase 'D' */ > This defines the device tree bindings for the Toshiba TC3589x > series of multi-purpose expanders. Only the stuff I can

[PATCH 1/5] mfd: tc3589x: add device tree bindings

2013-10-15 Thread Linus Walleij
This defines the device tree bindings for the Toshiba TC3589x series of multi-purpose expanders. Only the stuff I can test is defined: GPIO and keypad. Others may implement more subdevices further down the road. Signed-off-by: Linus Walleij --- Documentation/devicetree/bindings/mfd/tc3589x.txt |