Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On 10/31/2014 08:49 AM, Joonsoo Kim wrote: > On Wed, Oct 29, 2014 at 02:51:11PM +0100, Vlastimil Babka wrote: >> On 10/28/2014 08:16 AM, Joonsoo Kim wrote:> On Mon, Oct 27, 2014 at >> 10:11:31AM +0100, Vlastimil Babka wrote: >> >> I thought that the second check in compaction_suitable() makes sure

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On 10/31/2014 08:49 AM, Joonsoo Kim wrote: On Wed, Oct 29, 2014 at 02:51:11PM +0100, Vlastimil Babka wrote: On 10/28/2014 08:16 AM, Joonsoo Kim wrote: On Mon, Oct 27, 2014 at 10:11:31AM +0100, Vlastimil Babka wrote: I thought that the second check in compaction_suitable() makes sure of this,

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On Wed, Oct 29, 2014 at 02:51:11PM +0100, Vlastimil Babka wrote: > On 10/28/2014 08:16 AM, Joonsoo Kim wrote:> On Mon, Oct 27, 2014 at > 10:11:31AM +0100, Vlastimil Babka wrote: > >> On 10/27/2014 07:46 AM, Joonsoo Kim wrote: > >>> On Tue, Oct 07, 2014 at 05:33:35PM +0200, Vlastimil Babka wrote: >

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On Wed, Oct 29, 2014 at 02:51:11PM +0100, Vlastimil Babka wrote: On 10/28/2014 08:16 AM, Joonsoo Kim wrote: On Mon, Oct 27, 2014 at 10:11:31AM +0100, Vlastimil Babka wrote: On 10/27/2014 07:46 AM, Joonsoo Kim wrote: On Tue, Oct 07, 2014 at 05:33:35PM +0200, Vlastimil Babka wrote: Hello,

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On 10/28/2014 08:16 AM, Joonsoo Kim wrote:> On Mon, Oct 27, 2014 at 10:11:31AM +0100, Vlastimil Babka wrote: >> On 10/27/2014 07:46 AM, Joonsoo Kim wrote: >>> On Tue, Oct 07, 2014 at 05:33:35PM +0200, Vlastimil Babka wrote: >>> >>> Hello, >>> >>> compaction_suitable() has one more

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On 10/28/2014 08:16 AM, Joonsoo Kim wrote: On Mon, Oct 27, 2014 at 10:11:31AM +0100, Vlastimil Babka wrote: On 10/27/2014 07:46 AM, Joonsoo Kim wrote: On Tue, Oct 07, 2014 at 05:33:35PM +0200, Vlastimil Babka wrote: Hello, compaction_suitable() has one more zone_watermark_ok(). Why is it

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On Mon, Oct 27, 2014 at 10:11:31AM +0100, Vlastimil Babka wrote: > On 10/27/2014 07:46 AM, Joonsoo Kim wrote: > > On Tue, Oct 07, 2014 at 05:33:35PM +0200, Vlastimil Babka wrote: > > > > Hello, > > > > compaction_suitable() has one more zone_watermark_ok(). Why is it > > unchanged? > > Hi, > >

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On Mon, Oct 27, 2014 at 10:11:31AM +0100, Vlastimil Babka wrote: On 10/27/2014 07:46 AM, Joonsoo Kim wrote: On Tue, Oct 07, 2014 at 05:33:35PM +0200, Vlastimil Babka wrote: Hello, compaction_suitable() has one more zone_watermark_ok(). Why is it unchanged? Hi, it's a check

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On 10/27/2014 07:46 AM, Joonsoo Kim wrote: > On Tue, Oct 07, 2014 at 05:33:35PM +0200, Vlastimil Babka wrote: > > Hello, > > compaction_suitable() has one more zone_watermark_ok(). Why is it > unchanged? Hi, it's a check whether there are enough free pages to perform compaction, which means

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On Tue, Oct 07, 2014 at 05:33:35PM +0200, Vlastimil Babka wrote: > Compaction relies on zone watermark checks for decisions such as if it's worth > to start compacting in compaction_suitable() or whether compaction should stop > in compact_finished(). The watermark checks take classzone_idx and

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On Tue, Oct 07, 2014 at 05:33:35PM +0200, Vlastimil Babka wrote: Compaction relies on zone watermark checks for decisions such as if it's worth to start compacting in compaction_suitable() or whether compaction should stop in compact_finished(). The watermark checks take classzone_idx and

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On 10/27/2014 07:46 AM, Joonsoo Kim wrote: On Tue, Oct 07, 2014 at 05:33:35PM +0200, Vlastimil Babka wrote: Hello, compaction_suitable() has one more zone_watermark_ok(). Why is it unchanged? Hi, it's a check whether there are enough free pages to perform compaction, which means enough

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On 10/07/2014 11:33 AM, Vlastimil Babka wrote: Compaction relies on zone watermark checks for decisions such as if it's worth to start compacting in compaction_suitable() or whether compaction should stop in compact_finished(). The watermark checks take classzone_idx and alloc_flags parameters,

Re: [PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

On 10/07/2014 11:33 AM, Vlastimil Babka wrote: Compaction relies on zone watermark checks for decisions such as if it's worth to start compacting in compaction_suitable() or whether compaction should stop in compact_finished(). The watermark checks take classzone_idx and alloc_flags parameters,

[PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

Compaction relies on zone watermark checks for decisions such as if it's worth to start compacting in compaction_suitable() or whether compaction should stop in compact_finished(). The watermark checks take classzone_idx and alloc_flags parameters, which are related to the memory allocation

[PATCH 1/5] mm, compaction: pass classzone_idx and alloc_flags to watermark checking

Compaction relies on zone watermark checks for decisions such as if it's worth to start compacting in compaction_suitable() or whether compaction should stop in compact_finished(). The watermark checks take classzone_idx and alloc_flags parameters, which are related to the memory allocation