Re: [PATCH 1/5] objtool: Change REG_SP_INDIRECT

2021-02-03 Thread Josh Poimboeuf
On Wed, Feb 03, 2021 at 03:49:02PM +0100, Peter Zijlstra wrote: > On Wed, Feb 03, 2021 at 08:42:15AM -0600, Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 01:02:23PM +0100, Peter Zijlstra wrote: > > > Currently REG_SP_INDIRECT is unused but means (%rsp + offset), > > > change it to mean (%rsp) +

Re: [PATCH 1/5] objtool: Change REG_SP_INDIRECT

2021-02-03 Thread Peter Zijlstra
On Wed, Feb 03, 2021 at 08:42:15AM -0600, Josh Poimboeuf wrote: > On Wed, Feb 03, 2021 at 01:02:23PM +0100, Peter Zijlstra wrote: > > Currently REG_SP_INDIRECT is unused but means (%rsp + offset), > > change it to mean (%rsp) + offset. > > > > This is somewhat unfortunate, since REG_BP_INDIRECT is

Re: [PATCH 1/5] objtool: Change REG_SP_INDIRECT

2021-02-03 Thread Josh Poimboeuf
On Wed, Feb 03, 2021 at 01:02:23PM +0100, Peter Zijlstra wrote: > Currently REG_SP_INDIRECT is unused but means (%rsp + offset), > change it to mean (%rsp) + offset. > > This is somewhat unfortunate, since REG_BP_INDIRECT is used (by DRAP) > and thus needs to retain the current (%rbp + offset). O

[PATCH 1/5] objtool: Change REG_SP_INDIRECT

2021-02-03 Thread Peter Zijlstra
Currently REG_SP_INDIRECT is unused but means (%rsp + offset), change it to mean (%rsp) + offset. This is somewhat unfortunate, since REG_BP_INDIRECT is used (by DRAP) and thus needs to retain the current (%rbp + offset). Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/kernel/unwind_orc.c |