Re: [PATCH 1/5] perf: fix broken union in perf_event_mmap_page

2013-07-16 Thread H. Peter Anvin
On 06/28/2013 08:22 AM, Peter Zijlstra wrote: > > Ick, it did that!? and here I thought there was a difference between: > > int foo:1, > bar:1; > > and > > int foo:1; > int bar:1; > > That made all the difference in this particular case. I guess I should > go read the language

Re: [PATCH 1/5] perf: fix broken union in perf_event_mmap_page

2013-07-16 Thread H. Peter Anvin
On 06/28/2013 08:22 AM, Peter Zijlstra wrote: Ick, it did that!? and here I thought there was a difference between: int foo:1, bar:1; and int foo:1; int bar:1; That made all the difference in this particular case. I guess I should go read the language spec more

Re: [PATCH 1/5] perf: fix broken union in perf_event_mmap_page

2013-06-28 Thread Peter Zijlstra
On Fri, Jun 28, 2013 at 04:22:17PM +0300, Adrian Hunter wrote: > The capabilities bits must not be "union'ed" together. > Put them in a separate struct. > > Signed-off-by: Adrian Hunter > --- > include/uapi/linux/perf_event.h | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >

[PATCH 1/5] perf: fix broken union in perf_event_mmap_page

2013-06-28 Thread Adrian Hunter
The capabilities bits must not be "union'ed" together. Put them in a separate struct. Signed-off-by: Adrian Hunter --- include/uapi/linux/perf_event.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h

[PATCH 1/5] perf: fix broken union in perf_event_mmap_page

2013-06-28 Thread Adrian Hunter
The capabilities bits must not be union'ed together. Put them in a separate struct. Signed-off-by: Adrian Hunter adrian.hun...@intel.com --- include/uapi/linux/perf_event.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/perf_event.h

Re: [PATCH 1/5] perf: fix broken union in perf_event_mmap_page

2013-06-28 Thread Peter Zijlstra
On Fri, Jun 28, 2013 at 04:22:17PM +0300, Adrian Hunter wrote: The capabilities bits must not be union'ed together. Put them in a separate struct. Signed-off-by: Adrian Hunter adrian.hun...@intel.com --- include/uapi/linux/perf_event.h | 8 +--- 1 file changed, 5 insertions(+), 3