Re: [PATCH 1/5] proc: use down_read_killable for /proc/pid/maps

2019-05-17 Thread Michal Hocko
On Wed 15-05-19 11:41:12, Konstantin Khlebnikov wrote: > Do not stuck forever if something wrong. > This function also used for /proc/pid/smaps. I do agree that the killable variant is better but I do not understand the changelog. What would keep the lock blocked for ever? I do not think we have w

Re: [PATCH 1/5] proc: use down_read_killable for /proc/pid/maps

2019-05-15 Thread Kirill Tkhai
On 15.05.2019 11:41, Konstantin Khlebnikov wrote: > Do not stuck forever if something wrong. > This function also used for /proc/pid/smaps. > > Signed-off-by: Konstantin Khlebnikov For the series: Reviewed-by: Kirill Tkhai > --- > fs/proc/task_mmu.c |6 +- > fs/proc/task_nommu.c |

Re: [PATCH 1/5] proc: use down_read_killable for /proc/pid/maps

2019-05-15 Thread Cyrill Gorcunov
On Wed, May 15, 2019 at 11:41:12AM +0300, Konstantin Khlebnikov wrote: > Do not stuck forever if something wrong. > This function also used for /proc/pid/smaps. > > Signed-off-by: Konstantin Khlebnikov All patches in series look ok to me (actually I thought if there is a scenario where might_sle

[PATCH 1/5] proc: use down_read_killable for /proc/pid/maps

2019-05-15 Thread Konstantin Khlebnikov
Do not stuck forever if something wrong. This function also used for /proc/pid/smaps. Signed-off-by: Konstantin Khlebnikov --- fs/proc/task_mmu.c |6 +- fs/proc/task_nommu.c |6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task